Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes updating issue when used with Laravel Nova #163

Closed
wants to merge 2 commits into from

Conversation

u12206050
Copy link

This checks if a translation object exists on the model, which only exists when loaded through Nova with the language field.
This should be enough for this package to officially support Laravel Nova :)

Hope you can publish this asap as I use it in production already.

This checks if a translation object exists on the model, which only exists when loaded through Nova with the language field.
This should be enough for this package to officially support Laravel Nova :)
@u12206050 u12206050 mentioned this pull request Jul 29, 2020
@stale
Copy link

stale bot commented Aug 12, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 12, 2020
@stale stale bot removed the stale label Aug 13, 2020
Removes duplicate code
@stale
Copy link

stale bot commented Sep 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 7, 2020
@Gummibeer
Copy link
Member

@p-andrey could you check if a change like this fixes your issue in #215 ?
If so this PR has to be adjusted to pass all tests and should also add a test case for the new functionality.

@github-actions github-actions bot removed the stale label Oct 7, 2022
@github-actions github-actions bot added the stale label Oct 29, 2022
@github-actions github-actions bot closed this Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants