Commented out the attributes that are not implemented in Burrito #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
xml_converter/integration_tests/test_cases/xml_animation_speed/output_proto/markers.bin
Outdated
Show resolved
Hide resolved
xml_converter/integration_tests/test_cases/xml_category_inheritance/output_proto/markers.bin
Outdated
Show resolved
Hide resolved
xml_converter/integration_tests/test_cases/xml_fade_distance/output_proto/markers.bin
Outdated
Show resolved
Hide resolved
|
As discussed offline we will:
|
… the proto if we do not know how it will be implemented in Burrito
...verter/integration_tests/test_cases/proto_constant_size_on_map/input/pack/markers.guildpoint
Outdated
Show resolved
Hide resolved
...rter/integration_tests/test_cases/proto_constant_size_on_map/output_proto/markers.guildpoint
Outdated
Show resolved
Hide resolved
xml_converter/integration_tests/test_cases/proto_hide_category/input/pack/markers.guildpoint
Outdated
Show resolved
Hide resolved
xml_converter/integration_tests/test_cases/proto_hide_category/output_proto/markers.guildpoint
Outdated
Show resolved
Hide resolved
...integration_tests/test_cases/xml_achievement_bit_index_valid/output_proto/markers.guildpoint
Outdated
Show resolved
Hide resolved
xml_converter/integration_tests/test_cases/xml_achievement_id/output_proto/markers.guildpoint
Outdated
Show resolved
Hide resolved
xml_converter/integration_tests/test_cases/xml_animation_speed/output_proto/markers.guildpoint
Outdated
Show resolved
Hide resolved
xml_converter/integration_tests/test_cases/xml_canfade_valid/output_proto/markers.guildpoint
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/xml_category_inheritance/output_proto/markers.guildpoint.textproto._old 2024-12-14 02:36:29.366633600 +0000
+++ xml_converter/integration_tests/test_cases/xml_category_inheritance/output_proto/markers.guildpoint.textproto._new 2024-12-14 02:36:29.374633585 +0000
@@ -71,7 +71,6 @@
points_z: 8
points_z: 9
}
- animation_speed: 1
}
id: "\361@\242\320/\212\204\001"
}
xml_converter/integration_tests/test_cases/xml_fade_distance/output_proto/markers.guildpoint
Outdated
Show resolved
Hide resolved
...rter/integration_tests/test_cases/xml_scale_on_map_with_zoom/output_proto/markers.guildpoint
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/proto_constant_size_on_map/input/pack/markers.guildpoint.textproto._old 2024-12-14 03:12:51.064662971 +0000
+++ xml_converter/integration_tests/test_cases/proto_constant_size_on_map/input/pack/markers.guildpoint.textproto._new 2024-12-14 03:12:51.068662994 +0000
@@ -1,38 +0,0 @@
-category {
- name: "My Category"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- constant_size_on_map: true
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- constant_size_on_map: true
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- id: "(\350\314\006\302\223^\226"
-}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/proto_constant_size_on_map/output_proto/markers.guildpoint.textproto._old 2024-12-14 03:12:51.081663071 +0000
+++ xml_converter/integration_tests/test_cases/proto_constant_size_on_map/output_proto/markers.guildpoint.textproto._new 2024-12-14 03:12:51.084663088 +0000
@@ -1,38 +0,0 @@
-category {
- name: "My Category"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- constant_size_on_map: true
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- constant_size_on_map: true
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- id: "(\350\314\006\302\223^\226"
-}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/proto_hide_category/input/pack/markers.guildpoint.textproto._old 2024-12-14 03:12:51.096663159 +0000
+++ xml_converter/integration_tests/test_cases/proto_hide_category/input/pack/markers.guildpoint.textproto._new 2024-12-14 03:12:51.099663176 +0000
@@ -1,50 +0,0 @@
-category {
- name: "My Category"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- is_hidden: true
- id: "(\350\314\006\302\223^\226"
-}
-category {
- name: "My Category 2"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- id: "(\355i\3404\0141b"
-}
-category {
- name: "My Category 3"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- is_hidden: true
- id: "(\355i\3405\0141b"
-}
-category {
- name: "My Category 4"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- id: "(\355i\3406\0141b"
-}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/proto_hide_category/output_proto/markers.guildpoint.textproto._old 2024-12-14 03:12:51.110663241 +0000
+++ xml_converter/integration_tests/test_cases/proto_hide_category/output_proto/markers.guildpoint.textproto._new 2024-12-14 03:12:51.114663265 +0000
@@ -1,50 +0,0 @@
-category {
- name: "My Category"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- is_hidden: true
- id: "(\350\314\006\302\223^\226"
-}
-category {
- name: "My Category 2"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- id: "(\355i\3404\0141b"
-}
-category {
- name: "My Category 3"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- is_hidden: true
- id: "(\355i\3405\0141b"
-}
-category {
- name: "My Category 4"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- id: "(\355i\3406\0141b"
-}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/xml_achievement_bit_index_valid/output_proto/markers.guildpoint.textproto._old 2024-12-14 03:12:51.125663329 +0000
+++ xml_converter/integration_tests/test_cases/xml_achievement_bit_index_valid/output_proto/markers.guildpoint.textproto._new 2024-12-14 03:12:51.129663353 +0000
@@ -1,33 +0,0 @@
-category {
- name: "My Category"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- achievement_bit_index: 5
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- achievement_bit_index: 2147483647
- }
- trail {
- achievement_bit_index: 5
- }
- id: "(\350\314\006\302\223^\226"
-}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/xml_achievement_id/output_proto/markers.guildpoint.textproto._old 2024-12-14 03:12:51.141663423 +0000
+++ xml_converter/integration_tests/test_cases/xml_achievement_id/output_proto/markers.guildpoint.textproto._new 2024-12-14 03:12:51.144663441 +0000
@@ -1,60 +0,0 @@
-category {
- name: "My Category"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- achievement_id: 1
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- achievement_id: 5
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- achievement_id: 2147483647
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- achievement_id: -2147483648
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- achievement_id: -5
- }
- trail {
- achievement_id: 5
- }
- id: "(\350\314\006\302\223^\226"
-}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/xml_animation_speed/output_proto/markers.guildpoint.textproto._old 2024-12-14 03:12:51.156663512 +0000
+++ xml_converter/integration_tests/test_cases/xml_animation_speed/output_proto/markers.guildpoint.textproto._new 2024-12-14 03:12:51.159663529 +0000
@@ -1,182 +0,0 @@
-category {
- name: "My Category"
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: 1
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: 3.14
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: 123.456
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: 1
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: 3.14
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: 123.456
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: -3.14
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: -123.456
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: -3.14
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: -123.456
- }
- id: "(\350\314\006\302\223^\226"
-}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/xml_canfade_valid/output_proto/markers.guildpoint.textproto._old 2024-12-14 03:12:51.171663600 +0000
+++ xml_converter/integration_tests/test_cases/xml_canfade_valid/output_proto/markers.guildpoint.textproto._new 2024-12-14 03:12:51.174663617 +0000
@@ -1,38 +0,0 @@
-category {
- name: "My Category"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- disable_player_cutout: true
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- disable_player_cutout: true
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- id: "(\350\314\006\302\223^\226"
-}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/xml_category_inheritance/output_proto/markers.guildpoint.textproto._old 2024-12-14 03:12:51.186663688 +0000
+++ xml_converter/integration_tests/test_cases/xml_category_inheritance/output_proto/markers.guildpoint.textproto._new 2024-12-14 03:12:51.194663735 +0000
@@ -71,7 +71,6 @@
points_z: 8
points_z: 9
}
- animation_speed: 1
}
id: "\361@\242\320/\212\204\001"
}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/xml_fade_distance/output_proto/markers.guildpoint.textproto._old 2024-12-14 03:12:51.205663799 +0000
+++ xml_converter/integration_tests/test_cases/xml_fade_distance/output_proto/markers.guildpoint.textproto._new 2024-12-14 03:12:51.209663823 +0000
@@ -1,87 +0,0 @@
-category {
- name: "My Category"
- icon {
- map_id: 50
- distance_fade_end: 1
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- distance_fade_end: 3.14
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- distance_fade_end: 123.456
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- distance_fade_end: 3.14159
- distance_fade_start: 3.14
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- distance_fade_end: 123.456
- distance_fade_start: 3.14
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- distance_fade_end: 3.14
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- distance_fade_end: 123.456
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- trail {
- distance_fade_end: 3.14
- }
- trail {
- distance_fade_end: 3.14159
- distance_fade_start: 3.14
- }
- trail {
- distance_fade_end: 3.14
- }
- id: "(\350\314\006\302\223^\226"
-}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/xml_scale_on_map_with_zoom/output_proto/markers.guildpoint.textproto._old 2024-12-14 03:12:51.220663888 +0000
+++ xml_converter/integration_tests/test_cases/xml_scale_on_map_with_zoom/output_proto/markers.guildpoint.textproto._new 2024-12-14 03:12:51.223663905 +0000
@@ -1,38 +0,0 @@
-category {
- name: "My Category"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- constant_size_on_map: true
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- constant_size_on_map: true
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- id: "(\350\314\006\302\223^\226"
-}
AsherGlick
requested changes
Dec 22, 2024
There was a problem hiding this comment.
Also make an issue that indicates how to undo the changes you are making to the unit tests that can no longer be tested. Just including a simple git command with the commit hash right before this PR as a way to revert the files is good enough. Someone could of course just search for that hash, or rewrite the tests but might as well have it recorded in an easy to find location.
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/proto_constant_size_on_map/input/pack/markers.guildpoint.textproto._old 2025-01-10 01:36:20.533579778 +0000
+++ xml_converter/integration_tests/test_cases/proto_constant_size_on_map/input/pack/markers.guildpoint.textproto._new 2025-01-10 01:36:20.536579781 +0000
@@ -1,38 +0,0 @@
-category {
- name: "My Category"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- constant_size_on_map: true
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- constant_size_on_map: true
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- id: "(\350\314\006\302\223^\226"
-}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/proto_constant_size_on_map/output_proto/markers.guildpoint.textproto._old 2025-01-10 01:36:20.549579798 +0000
+++ xml_converter/integration_tests/test_cases/proto_constant_size_on_map/output_proto/markers.guildpoint.textproto._new 2025-01-10 01:36:20.552579802 +0000
@@ -1,38 +0,0 @@
-category {
- name: "My Category"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- constant_size_on_map: true
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- constant_size_on_map: true
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- id: "(\350\314\006\302\223^\226"
-}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/proto_hide_category/input/pack/markers.guildpoint.textproto._old 2025-01-10 01:36:20.562579815 +0000
+++ xml_converter/integration_tests/test_cases/proto_hide_category/input/pack/markers.guildpoint.textproto._new 2025-01-10 01:36:20.566579820 +0000
@@ -1,50 +0,0 @@
-category {
- name: "My Category"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- is_hidden: true
- id: "(\350\314\006\302\223^\226"
-}
-category {
- name: "My Category 2"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- id: "(\355i\3404\0141b"
-}
-category {
- name: "My Category 3"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- is_hidden: true
- id: "(\355i\3405\0141b"
-}
-category {
- name: "My Category 4"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- id: "(\355i\3406\0141b"
-}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/proto_hide_category/output_proto/markers.guildpoint.textproto._old 2025-01-10 01:36:20.576579832 +0000
+++ xml_converter/integration_tests/test_cases/proto_hide_category/output_proto/markers.guildpoint.textproto._new 2025-01-10 01:36:20.580579838 +0000
@@ -1,50 +0,0 @@
-category {
- name: "My Category"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- is_hidden: true
- id: "(\350\314\006\302\223^\226"
-}
-category {
- name: "My Category 2"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- id: "(\355i\3404\0141b"
-}
-category {
- name: "My Category 3"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- is_hidden: true
- id: "(\355i\3405\0141b"
-}
-category {
- name: "My Category 4"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- id: "(\355i\3406\0141b"
-}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/xml_achievement_bit_index_valid/output_proto/markers.guildpoint.textproto._old 2025-01-10 01:36:20.590579850 +0000
+++ xml_converter/integration_tests/test_cases/xml_achievement_bit_index_valid/output_proto/markers.guildpoint.textproto._new 2025-01-10 01:36:20.594579855 +0000
@@ -1,33 +0,0 @@
-category {
- name: "My Category"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- achievement_bit_index: 5
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- achievement_bit_index: 2147483647
- }
- trail {
- achievement_bit_index: 5
- }
- id: "(\350\314\006\302\223^\226"
-}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/xml_achievement_id/output_proto/markers.guildpoint.textproto._old 2025-01-10 01:36:20.604579868 +0000
+++ xml_converter/integration_tests/test_cases/xml_achievement_id/output_proto/markers.guildpoint.textproto._new 2025-01-10 01:36:20.608579873 +0000
@@ -1,60 +0,0 @@
-category {
- name: "My Category"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- achievement_id: 1
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- achievement_id: 5
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- achievement_id: 2147483647
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- achievement_id: -2147483648
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- achievement_id: -5
- }
- trail {
- achievement_id: 5
- }
- id: "(\350\314\006\302\223^\226"
-}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/xml_animation_speed/output_proto/markers.guildpoint.textproto._old 2025-01-10 01:36:20.618579886 +0000
+++ xml_converter/integration_tests/test_cases/xml_animation_speed/output_proto/markers.guildpoint.textproto._new 2025-01-10 01:36:20.622579891 +0000
@@ -1,182 +0,0 @@
-category {
- name: "My Category"
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: 1
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: 3.14
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: 123.456
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: 1
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: 3.14
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: 123.456
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: -3.14
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: -123.456
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: -3.14
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: -123.456
- }
- id: "(\350\314\006\302\223^\226"
-}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/xml_canfade_valid/output_proto/markers.guildpoint.textproto._old 2025-01-10 01:36:20.632579904 +0000
+++ xml_converter/integration_tests/test_cases/xml_canfade_valid/output_proto/markers.guildpoint.textproto._new 2025-01-10 01:36:20.636579909 +0000
@@ -1,38 +0,0 @@
-category {
- name: "My Category"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- disable_player_cutout: true
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- disable_player_cutout: true
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- id: "(\350\314\006\302\223^\226"
-}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/xml_category_inheritance/output_proto/markers.guildpoint.textproto._old 2025-01-10 01:36:20.646579922 +0000
+++ xml_converter/integration_tests/test_cases/xml_category_inheritance/output_proto/markers.guildpoint.textproto._new 2025-01-10 01:36:20.654579932 +0000
@@ -71,7 +71,6 @@
points_z: 8
points_z: 9
}
- animation_speed: 1
}
id: "\361@\242\320/\212\204\001"
}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/xml_fade_distance/output_proto/markers.guildpoint.textproto._old 2025-01-10 01:36:20.665579946 +0000
+++ xml_converter/integration_tests/test_cases/xml_fade_distance/output_proto/markers.guildpoint.textproto._new 2025-01-10 01:36:20.669579951 +0000
@@ -1,87 +0,0 @@
-category {
- name: "My Category"
- icon {
- map_id: 50
- distance_fade_end: 1
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- distance_fade_end: 3.14
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- distance_fade_end: 123.456
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- distance_fade_end: 3.14159
- distance_fade_start: 3.14
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- distance_fade_end: 123.456
- distance_fade_start: 3.14
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- distance_fade_end: 3.14
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- distance_fade_end: 123.456
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- trail {
- distance_fade_end: 3.14
- }
- trail {
- distance_fade_end: 3.14159
- distance_fade_start: 3.14
- }
- trail {
- distance_fade_end: 3.14
- }
- id: "(\350\314\006\302\223^\226"
-}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/xml_scale_on_map_with_zoom/output_proto/markers.guildpoint.textproto._old 2025-01-10 01:36:20.679579964 +0000
+++ xml_converter/integration_tests/test_cases/xml_scale_on_map_with_zoom/output_proto/markers.guildpoint.textproto._new 2025-01-10 01:36:20.683579969 +0000
@@ -1,38 +0,0 @@
-category {
- name: "My Category"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- constant_size_on_map: true
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- constant_size_on_map: true
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- id: "(\350\314\006\302\223^\226"
-}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/proto_constant_size_on_map/input/pack/markers.guildpoint.textproto._old 2025-01-15 00:33:43.996275095 +0000
+++ xml_converter/integration_tests/test_cases/proto_constant_size_on_map/input/pack/markers.guildpoint.textproto._new 2025-01-15 00:33:43.999275114 +0000
@@ -1,38 +0,0 @@
-category {
- name: "My Category"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- constant_size_on_map: true
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- constant_size_on_map: true
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- id: "(\350\314\006\302\223^\226"
-}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/proto_constant_size_on_map/output_proto/markers.guildpoint.textproto._old 2025-01-15 00:33:44.011275190 +0000
+++ xml_converter/integration_tests/test_cases/proto_constant_size_on_map/output_proto/markers.guildpoint.textproto._new 2025-01-15 00:33:44.014275210 +0000
@@ -1,38 +0,0 @@
-category {
- name: "My Category"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- constant_size_on_map: true
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- constant_size_on_map: true
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- id: "(\350\314\006\302\223^\226"
-}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/proto_hide_category/input/pack/markers.guildpoint.textproto._old 2025-01-15 00:33:44.025275280 +0000
+++ xml_converter/integration_tests/test_cases/proto_hide_category/input/pack/markers.guildpoint.textproto._new 2025-01-15 00:33:44.028275299 +0000
@@ -1,50 +0,0 @@
-category {
- name: "My Category"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- is_hidden: true
- id: "(\350\314\006\302\223^\226"
-}
-category {
- name: "My Category 2"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- id: "(\355i\3404\0141b"
-}
-category {
- name: "My Category 3"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- is_hidden: true
- id: "(\355i\3405\0141b"
-}
-category {
- name: "My Category 4"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- id: "(\355i\3406\0141b"
-}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/proto_hide_category/output_proto/markers.guildpoint.textproto._old 2025-01-15 00:33:44.039275369 +0000
+++ xml_converter/integration_tests/test_cases/proto_hide_category/output_proto/markers.guildpoint.textproto._new 2025-01-15 00:33:44.042275388 +0000
@@ -1,50 +0,0 @@
-category {
- name: "My Category"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- is_hidden: true
- id: "(\350\314\006\302\223^\226"
-}
-category {
- name: "My Category 2"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- id: "(\355i\3404\0141b"
-}
-category {
- name: "My Category 3"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- is_hidden: true
- id: "(\355i\3405\0141b"
-}
-category {
- name: "My Category 4"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- id: "(\355i\3406\0141b"
-}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/xml_achievement_bit_index_valid/output_proto/markers.guildpoint.textproto._old 2025-01-15 00:33:44.052275451 +0000
+++ xml_converter/integration_tests/test_cases/xml_achievement_bit_index_valid/output_proto/markers.guildpoint.textproto._new 2025-01-15 00:33:44.056275477 +0000
@@ -1,33 +0,0 @@
-category {
- name: "My Category"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- achievement_bit_index: 5
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- achievement_bit_index: 2147483647
- }
- trail {
- achievement_bit_index: 5
- }
- id: "(\350\314\006\302\223^\226"
-}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/xml_achievement_id/output_proto/markers.guildpoint.textproto._old 2025-01-15 00:33:44.067275547 +0000
+++ xml_converter/integration_tests/test_cases/xml_achievement_id/output_proto/markers.guildpoint.textproto._new 2025-01-15 00:33:44.070275566 +0000
@@ -1,60 +0,0 @@
-category {
- name: "My Category"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- achievement_id: 1
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- achievement_id: 5
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- achievement_id: 2147483647
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- achievement_id: -2147483648
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- achievement_id: -5
- }
- trail {
- achievement_id: 5
- }
- id: "(\350\314\006\302\223^\226"
-}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/xml_animation_speed/output_proto/markers.guildpoint.textproto._old 2025-01-15 00:33:44.081275636 +0000
+++ xml_converter/integration_tests/test_cases/xml_animation_speed/output_proto/markers.guildpoint.textproto._new 2025-01-15 00:33:44.084275655 +0000
@@ -1,182 +0,0 @@
-category {
- name: "My Category"
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: 1
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: 3.14
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: 123.456
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: 1
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: 3.14
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: 123.456
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: -3.14
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: -123.456
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: -3.14
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: -123.456
- }
- id: "(\350\314\006\302\223^\226"
-}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/xml_canfade_valid/output_proto/markers.guildpoint.textproto._old 2025-01-15 00:33:44.096275731 +0000
+++ xml_converter/integration_tests/test_cases/xml_canfade_valid/output_proto/markers.guildpoint.textproto._new 2025-01-15 00:33:44.099275751 +0000
@@ -1,38 +0,0 @@
-category {
- name: "My Category"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- disable_player_cutout: true
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- disable_player_cutout: true
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- id: "(\350\314\006\302\223^\226"
-}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/xml_category_inheritance/output_proto/markers.guildpoint.textproto._old 2025-01-15 00:33:44.110275821 +0000
+++ xml_converter/integration_tests/test_cases/xml_category_inheritance/output_proto/markers.guildpoint.textproto._new 2025-01-15 00:33:44.118275872 +0000
@@ -71,7 +71,6 @@
points_z: 8
points_z: 9
}
- animation_speed: 1
}
id: "\361@\242\320/\212\204\001"
}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/xml_fade_distance/output_proto/markers.guildpoint.textproto._old 2025-01-15 00:33:44.129275942 +0000
+++ xml_converter/integration_tests/test_cases/xml_fade_distance/output_proto/markers.guildpoint.textproto._new 2025-01-15 00:33:44.132275961 +0000
@@ -1,87 +0,0 @@
-category {
- name: "My Category"
- icon {
- map_id: 50
- distance_fade_end: 1
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- distance_fade_end: 3.14
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- distance_fade_end: 123.456
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- distance_fade_end: 3.14159
- distance_fade_start: 3.14
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- distance_fade_end: 123.456
- distance_fade_start: 3.14
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- distance_fade_end: 3.14
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- distance_fade_end: 123.456
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- trail {
- distance_fade_end: 3.14
- }
- trail {
- distance_fade_end: 3.14159
- distance_fade_start: 3.14
- }
- trail {
- distance_fade_end: 3.14
- }
- id: "(\350\314\006\302\223^\226"
-}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/xml_scale_on_map_with_zoom/output_proto/markers.guildpoint.textproto._old 2025-01-15 00:33:44.144276037 +0000
+++ xml_converter/integration_tests/test_cases/xml_scale_on_map_with_zoom/output_proto/markers.guildpoint.textproto._new 2025-01-15 00:33:44.148276062 +0000
@@ -1,38 +0,0 @@
-category {
- name: "My Category"
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- constant_size_on_map: true
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- constant_size_on_map: true
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- id: "(\350\314\006\302\223^\226"
-}
AsherGlick
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comments out the unoptimized proto fields so they can be used later. These fields are not currently used within Burrito so they can be added as they are optimized.
More details behind the reason for this can be found in #151