core: fix potential undefined function error with transient hooks

Fixes syl20bnr#10930
Asgavar · Jul 4, 2018 · a861177 · a861177
1 parent ba2f692
commit a861177
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/core/core-hooks.el b/core/core-hooks.el
@@ -53,8 +53,11 @@ If FUNC is a lambda you must give it a name with FNAME. "
                                     ,(if (functionp hook)
                                          `(advice-remove ',hook ',hfunc)
                                        `(remove-hook ',hook ',hfunc))
-                                    (fmakunbound ',hfunc)
-                                    ,(when fname `(fmakunbound ',fname)))))
+                                    ;; instead of unbinding we reset the
+                                    ;; functions to be the `ignore' function.
+                                    ;; see: https://github.com/syl20bnr/spacemacs/issues/10930
+                                    (fset ',hfunc 'ignore)
+                                    ,(when fname `(fset ',fname 'ignore)))))
                   (if (functionp hook)
                       `((advice-add ',hook :before ',hfunc))
                     `((add-hook ',hook ',hfunc)))))