power: supply: macsmc: make force-discharge to the charge limit configurable#521
Open
BoiledElectricity wants to merge 1 commit into
Open
Conversation
…gurable When lowering the charge-control end threshold on machines that use the CHLS key, the driver unconditionally sets CHLS_FORCE_DISCHARGE, actively draining the battery down to the limit even on AC power. Most laptop charge-limit implementations instead just cap charging at the threshold and let the battery drain naturally through use. Add a "force_discharge" module parameter (default on, preserving the existing behaviour) so users can opt out of active discharge and have the charge limit only cap charging. Resolves the existing TODO. Signed-off-by: James A DellaMorte <james.dellamorte@gmail.com>
Author
|
Tested on Apple MacBook Pro 13" M1 (j293), kernel 6.19.14, on AC at 100% (this firmware uses the
Battery restored to 100% / default afterwards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lowering the charge limit always sets
CHLS_FORCE_DISCHARGE, so the battery actively drains down to the limit even on AC. Add aforce_dischargemodule param (default on = no behaviour change) to make that opt-out, so the limit can just cap charging instead.Resolves the in-code TODO. Tested on M1 MacBook Pro (j293).