Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vue Example #134

Merged
merged 7 commits into from
Jan 23, 2025
Merged

Conversation

themetalfleece
Copy link
Contributor

@themetalfleece themetalfleece commented Jan 22, 2025

  • Update the overall example to be in line with the react one (React example (using Vue example as reference) #130).
  • Upgrade all packages to their latest versions.
  • Import mupdf directly and use the mupdfjs high level wrapper.
  • Adjust the vite config to make this work with production builds.
  • Update the prettier config file to enforce semicolons (I found inconsistent formatting in the files).
  • Remove unnecessary async/await if not needed.
  • Add comments in the code.
  • Add "Notable Files" in the README.
  • Replace .eslintrc.cjs with eslint.config.js, so it works with eslint 9.

As usual, I've tested locally both the dev and the production build, and it works as intended. Same experience with React, a few minor warnings on build, but no warnings or errors on runtime.
Please let me know if anything's amiss!

Copy link
Collaborator

@jamie-lemon jamie-lemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamie-lemon jamie-lemon merged commit a47cccb into ArtifexSoftware:master Jan 23, 2025
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2025
@themetalfleece themetalfleece deleted the vue-update branch January 24, 2025 08:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants