Skip to content

chore: php 8.4 support #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
# - name: Setup PHP
# uses: shivammathur/setup-php@v2
# with:
# php-version: "8.2"
# php-version: "8.4"
# extensions: mbstring, dom, fileinfo, intl, gd, imagick, bcmath, soap, zip, sqlite, pcov
# coverage: pcov

Expand Down Expand Up @@ -65,7 +65,7 @@ jobs:
- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: "8.2"
php-version: "8.4"
extensions: mbstring, dom, fileinfo, intl, gd, imagick, bcmath, soap, zip, sqlite, pcov
coverage: pcov

Expand All @@ -74,6 +74,8 @@ jobs:

- name: Run php-cs-fixer
run: composer format
env:
PHP_CS_FIXER_IGNORE_ENV: true # TODO: Remove this line when php-cs-fixer is updated

- uses: stefanzweifel/git-auto-commit-action@v4
with:
Expand All @@ -94,7 +96,7 @@ jobs:
- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: "8.2"
php-version: "8.4"
extensions: mbstring, dom, fileinfo, intl, gd, imagick, bcmath, soap, zip, sqlite, pcov
coverage: pcov

Expand Down
2 changes: 1 addition & 1 deletion src/API/Node.php
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public function crypto(): ?array
*
* @return array
*/
public function fees(int $days = null): ?array
public function fees(?int $days = null): ?array
{
return $this->get('node/fees', ['days' => $days]);
}
Expand Down
2 changes: 1 addition & 1 deletion src/ArkClient.php
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class ArkClient
*
* @throws InvalidArgumentException if $hostOrHosts is an array and does not have the required format
*/
public function __construct(array|string $hostOrHosts, array $clientConfig = [], HandlerStack $handler = null)
public function __construct(array|string $hostOrHosts, array $clientConfig = [], ?HandlerStack $handler = null)
{
$this->validateHosts($hostOrHosts);

Expand Down
4 changes: 2 additions & 2 deletions src/ClientManager.php
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public function connect(string $host, string $name = 'main'): ArkClient
*
* @param string|null $name
*/
public function disconnect(string $name = null): void
public function disconnect(?string $name = null): void
{
$name = $name ?? $this->getDefaultClient();

Expand All @@ -63,7 +63,7 @@ public function disconnect(string $name = null): void
*
* @return ArkClient
*/
public function client(string $name = null): ArkClient
public function client(?string $name = null): ArkClient
{
$name = $name ?? $this->getDefaultClient();

Expand Down
Loading