Suggested fixes #183

ianfixes · 2020-10-16T20:37:59Z

Trying it out

You can test this beta of the gem directly from github by putting this in your Gemfile:

gem 'arduino_ci', git: 'https://github.com/ianfixes/arduino_ci.git', branch: '2020-10-16_suggestions'

Highlights from `CHANGELOG.md`

Added

arduino_ci_remote.rb CLI switch --skip-examples-compilation
CppLibrary.header_files to find header files
LibraryProperties to read metadata from Arduino libraries
CppLibrary.library_properties_path, CppLibrary.library_properties?, CppLibrary.library_properties to expose library properties of a Cpp library
CppLibrary.arduino_library_dependencies to list the dependent libraries specified by the library.properties file

Changed

CppLibrary functions returning C++ header or code files now respect the 1.0/1.5 library specification

Deprecated

arduino_ci_remote.rb CLI switch --skip-compilation

Fixed

Don't define ostream& operator<<(nullptr_t) if already defined by Apple
CppLibrary.in_tests_dir? no longer produces an error if there is no tests directory
The definition of the _SFR_IO8 macro no longer produces errors about rvalues

See CHANGELOG.md for more

Issues Fixed

jgfoster · 2020-11-09T08:47:51Z

cpp/arduino/Arduino.h

@@ -5,6 +5,15 @@ Mock Arduino.h library.
 Where possible, variable names from the Arduino library are used to avoid conflicts

 */
+
+// hardware mocks
+volatile long long __ARDUINO_CI_SFR_MOCK[1024];


I believe that if you defined a variable in a header file then it gets defined every time that header file is included and you get multiple definitions. Instead, if you define it as extern in the header and then put it in a .cpp file, it will be created only once.

Also, I think this should declare a uin8_t* array, rather than a long long array. If not, I think that each byte in the original "address space" (i.e. offsets passed to _SFR_IOx macros) end up in different long long entries in this array, so multi-byte values do not map properly anymore (i.e. ADC maps to either ADCH or ADCL (dunno which off-hand), rather than being a combination of both).

Also, the current code violates strict type aliasing (accessing a longlong[] through a pointer of a different type is not allowed), which means the compiler might mess up optimizations regarding this array. I was hoping that making it a uint8_t array would solve this, but it seems this only works the other way around (accessing an arbitrary type through a uint8_t*). So maybe this needs access through a union to make it explicit to the compiler what's happening...

matthijskooijman

Just had a look at the io.h stuff, that (the last commit, the first one that "fixes" _SFR_IO8 only makes it broken in a different way) looks pretty much like what I had in mind for the first part of #193 (comment)

matthijskooijman · 2020-11-09T09:16:24Z

cpp/arduino/Arduino.h

+#define _SFR_IO16(io_addr) (*(volatile uint16_t *)(__ARDUINO_CI_SFR_MOCK + io_addr)) // this macro is all we need from the sfr file
+#define _SFR_MEM8(io_addr) (*(volatile uint8_t *)(__ARDUINO_CI_SFR_MOCK + io_addr)) // this macro is all we need from the sfr file
+#define _SFR_MEM16(io_addr) (*(volatile uint16_t *)(__ARDUINO_CI_SFR_MOCK + io_addr)) // this macro is all we need from the sfr file
+#define _SFR_MEM32(io_addr) (*(volatile uint32_t *)(__ARDUINO_CI_SFR_MOCK + io_addr)) // this macro is all we need from the sfr file


I would leave this stuff in io.h, which is where they are used and what any other code that (god knows why) uses them would expect them.

I'm looking at this and right now the issue is that SampleProjects/TestSomething/test/godmode.cpp fails the spi tests due to bytes being in the wrong order.

I'm not sure what you mean here? If you move this to io.h, that makes the tests fail? But not because of include order or something like that, but "byte order"?

Just for completeness, this conversation is continuing in #201.

ianfixes · 2020-11-11T03:15:21Z

Reverting 8180efb as per this #196 (comment)

The command line option --skip-compilation can be confusing, because unit tests must be compiled before they can run. This adds some text to the flag such that the fact that examples are compiled is acknowledged.

ianfixes force-pushed the 2020-10-16_suggestions branch 4 times, most recently from 5c6555c to 6196faa Compare October 19, 2020 03:36

ianfixes mentioned this pull request Oct 19, 2020

Multiple definition of 'main' when including a library with tests #168

Closed

ianfixes force-pushed the 2020-10-16_suggestions branch 2 times, most recently from 2b61e9c to 7ae62ae Compare October 27, 2020 03:01

This was referenced Oct 27, 2020

Create 16/32-bit compatible AVR Registers mocks, _SFR_MEM8 in particular #120

Closed

Mock for sleep and wdt #115

Merged

Do not compile tests from included libraries #188

Closed

ianfixes force-pushed the 2020-10-16_suggestions branch 5 times, most recently from 731e657 to 334b7aa Compare October 27, 2020 17:07

ianfixes mentioned this pull request Nov 4, 2020

Arduino CI seems to not handle dependencies between imported Arduino Libraries #192

Closed

Kavikick mentioned this pull request Nov 4, 2020

Stuck on testing Ethernet Class Open-Acidification/TankControllerLib#14

Closed

ianfixes mentioned this pull request Nov 7, 2020

_SFR_IO8 no longer visible after definition moved to a new file #196

Closed

jgfoster reviewed Nov 9, 2020

View reviewed changes

matthijskooijman reviewed Nov 9, 2020

View reviewed changes

jgfoster mentioned this pull request Nov 9, 2020

Possible direction for __ARDUINO_CI_SFR_MOCK #201

Closed

ianfixes force-pushed the 2020-10-16_suggestions branch from 8180efb to 9192004 Compare November 11, 2020 03:25

ianfixes added 7 commits November 10, 2020 22:30

Increase clarity of command line tool

a50d8a1

The command line option --skip-compilation can be confusing, because unit tests must be compiled before they can run. This adds some text to the flag such that the fact that examples are compiled is acknowledged.

Use proper 1.5 library format

4f6eb2a

Obey 1.0 / 1.5 library specification when finding C++ library source

9b4f31f

Appease rubocop

09b8cc2

avoid error when testing for membership in a nonexistent directory

8a14ad1

Add library.properties parsing

082ac95

Add recursive library dependency compilation

da1cef6

ianfixes mentioned this pull request Nov 11, 2020

Fixes #144

Closed

ianfixes force-pushed the 2020-10-16_suggestions branch from 9192004 to cdf136f Compare November 11, 2020 03:37

ianfixes mentioned this pull request Nov 11, 2020

Add support for EEPROM #184

Closed

ianfixes force-pushed the 2020-10-16_suggestions branch from cdf136f to f981320 Compare November 11, 2020 04:08

ianfixes added this to the OpenAcidification Support milestone Nov 11, 2020

ianfixes and others added 2 commits November 10, 2020 23:15

Remove hard-coded __AVR__ in favor of platform configured data

583f4a1

Support for EEPROM (squashed)

7978af6

ianfixes force-pushed the 2020-10-16_suggestions branch 2 times, most recently from 12d4ae7 to b0efa36 Compare November 11, 2020 04:29

ianfixes mentioned this pull request Nov 11, 2020

Add files needed to compile Ethernet library #180

Closed

Fix EEPROM compilation

4199092

ianfixes force-pushed the 2020-10-16_suggestions branch 10 times, most recently from 643caab to 53437a9 Compare November 13, 2020 05:07

James Foster and others added 4 commits November 13, 2020 00:14

Add files needed to compile Ethernet library (squashed)

cdecc40

Fix custom ethernet library location

a8eff6a

Implement __ARDUNO_CI_SFR_MOCK (squashed)

7804730

Don't test SFR on non-AVR

cbccf6a

ianfixes force-pushed the 2020-10-16_suggestions branch from 53437a9 to cbccf6a Compare November 13, 2020 05:15

Additional __ARDUINO_CI_SFR_MOCK commits (squashed)

ebfa6a7

ianfixes force-pushed the 2020-10-16_suggestions branch from 25ae225 to ebfa6a7 Compare November 13, 2020 05:49

Remove possible unnecessary preprocessor guard

b4ee115

ianfixes merged commit a438a59 into Arduino-CI:master Nov 13, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Suggested fixes #183

Suggested fixes #183

ianfixes commented Oct 16, 2020 •

edited

Loading

jgfoster Nov 9, 2020

matthijskooijman Nov 9, 2020

matthijskooijman left a comment

matthijskooijman Nov 9, 2020

jgfoster Nov 9, 2020

matthijskooijman Nov 9, 2020

jgfoster Nov 10, 2020

ianfixes commented Nov 11, 2020

Suggested fixes #183

Suggested fixes #183

Conversation

ianfixes commented Oct 16, 2020 • edited Loading

Trying it out

Highlights from CHANGELOG.md

Added

Changed

Deprecated

Fixed

Issues Fixed

jgfoster Nov 9, 2020

Choose a reason for hiding this comment

matthijskooijman Nov 9, 2020

Choose a reason for hiding this comment

matthijskooijman left a comment

Choose a reason for hiding this comment

matthijskooijman Nov 9, 2020

Choose a reason for hiding this comment

jgfoster Nov 9, 2020

Choose a reason for hiding this comment

matthijskooijman Nov 9, 2020

Choose a reason for hiding this comment

jgfoster Nov 10, 2020

Choose a reason for hiding this comment

ianfixes commented Nov 11, 2020

ianfixes commented Oct 16, 2020 •

edited

Loading

Highlights from `CHANGELOG.md`