Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common.xml: add fuel_pressure ext. to EFI_STATUS #297

Merged
merged 1 commit into from
Jan 2, 2023

Conversation

robertlong13
Copy link

Add support for reporting fuel pressure in the EFI_STATUS message. Fuel pressure is already measured and logged by multiple EFI backends, and it can be a useful measurement to report to the GCS for diagnosing problems on the ground.

kPa chosen as the unit to match the two other pressure fields in the message, though this is a departure from other pressure fields in other messages.

We could potentially add other missing fields at this time too, but this one is the most useful.

@peterbarker
Copy link

@hamishwillee FYI. We'll discuss this at DevCall tomorrow and then PR upstream

@hamishwillee
Copy link

Thanks @peterbarker - sounds good to me. As an aside, do you remember why we didn't enumerate EFI_STATUS.health. If not used perhaps we should make a comment on that too.

@tridge tridge merged commit 3b0256a into ArduPilot:master Jan 2, 2023
@magicrub
Copy link

magicrub commented Jan 2, 2023

@robertlong13 merged! Sounds like @hamishwillee also likes this so can you please make a matching "upstream" PR https://github.com/mavlink/mavlink

@hamishwillee
Copy link

Yes I like this, but it should have been created in mavlink/mavlink first and then filtered down to Ardupilot/mavlink - because it is in common. No guarantees that it will be loved by the broader community, who have much more expertise than me.

@robertlong13 robertlong13 deleted the efi_fuel_pressure branch February 3, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants