added splash screen, revamped login screen.#48
added splash screen, revamped login screen.#48nirbhaysinghnarang wants to merge 4 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Make sure you properly format everything in the files in the next commit so there's no random whitespace and things are easier to read. Take a look at my comments below for specific stuff.
Suggest we table this for now and move to other stuff since it'll require quite a bit of work to get looking good.
| <MainTab setLoggedIn={setLoggedIn} /> : | ||
| <Authentication /> | ||
| } | ||
| {/* {loggedIn ? |
There was a problem hiding this comment.
Make sure to uncomment this before merge
| /> | ||
| <ImageBackground | ||
|
|
||
| source={{ uri: "https://news.cornell.edu/sites/default/files/styles/full_size/public/UP_2017_0630_051.jpg?itok=MzKRS1G7" }} |
There was a problem hiding this comment.
Why is there random whitespace here? Remove and format properly
| width: windowWidth, | ||
| opacity: 0.8 | ||
| }, | ||
| loginScreenHeroImg: { |
There was a problem hiding this comment.
I think there's too much white space on the login page, I think the loginScreenHeroImg should take up more of the screen
| @@ -22,6 +22,8 @@ export default ({ navigation, route }) => { | |||
|
|
|||
| const [_] = useFonts({ | |||
There was a problem hiding this comment.
Idk where to leave this comment but I think you fiddling with the styles in styles.js screwed up the register page so it's not centered vertically anymore and also the icons are orange but so is the BG of register page, so make sure to fix that
| @@ -1,5 +1,5 @@ | |||
| import React, { useState, useEffect, useContext } from 'react'; | |||
There was a problem hiding this comment.
Idk where to put this specifically but a few things about the login page that need to be fixed:
- Login button is initially white so it's confusing for the user, and also looks kinda ugly, I think we should have the rounded button type thing we had before but the button is initially a black outline/text and then becomes orange with white text
- Too much white space between inputs and login button
- The yolo pill thing looks kind of ugly
2 participants
No description provided.