Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stardew Valley: Fixed Powdermelon and option inconsistencies #4632

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Stardew Valley: Fixed Powdermelon and option inconsistencies #4632

wants to merge 3 commits into from
+20 −19

Conversation

agilbert1412
Copy link
Collaborator

What is this fixing or adding?

  • Powdermelon growth season fixed to winter, it was mistakenly set as summer
  • Fixed several option tooltips that were inconsistent, unclear, or otherwise improved
  • Fixed one preset that had exclude ginger island yet was enabling walnutsanity

How was this tested?

Unit tests, and also ran the webhost locally to look at my changes

@agilbert1412 agilbert1412 added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Feb 11, 2025
@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Feb 11, 2025
Jouramie
Jouramie approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@Jouramie Jouramie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agilbert1412 agilbert1412 added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jouramie Jouramie Jouramie approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agilbert1412 @Jouramie