Various: Allow for --nogui client launches from the Launcher #4549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e checks for nogui
github-actions
bot
added
the
waiting-on: peer-review
ScipioWright
added
is: enhancement
|
Approving for kh2 |
nbrochu
approved these changes
Feb 4, 2025
CookieCat45
approved these changes
Feb 7, 2025
Zunawe
approved these changes
Feb 9, 2025
|
Looks good to me! |
qwint
added
waiting-on: core-review
Berserker66
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Mostly using the PR as a way to itemize the clients who have the ability to use --nogui but will currently fail to accept further user input if that arg is used from the launcher
update various components to use the new launch() if their client code checks for nogui
if any of these clients aren't actually expected to work with --nogui they don't need these changes but then they have unused/unneeded codepaths in their clients
modules with approval
How was this tested?
tested the functionality of LauncherComponents.launch in the PR that added it and with a unsupported client not in the PR but did not test all of the affected clients in the PR
If this makes graphical changes, please attach screenshots.