Core: Fix worlds that rely on other worlds having their Entrances connected before connect_entrances, add unit test #4530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NewSoupVi
added
is: bug/fix
NewSoupVi
added
the
waiting-on: world-maintainer
Exempt-Medic
requested changes
Jan 21, 2025
NewSoupVi
removed
the
waiting-on: world-maintainer
Berserker66
approved these changes
Jan 22, 2025
Exempt-Medic
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4527.
In #4420, we added a new step called connect_entrances.
The description of this step reads: "By the end of this step, all Entrances must be connected".
However, there are some worlds that are relying on other worlds not having any dangling entrances in set_rules (which is before connect_entrances).
The culprit here is get_all_state, which does region sweeps on all worlds.
Conveniently, get_all_state has an
allow_partial_entranceskwarg.So, this PR adds that arg to the two "offending" worlds, and adds a unit test to ensure that it is used.