Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LADX: tarins gift improvement #3970

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

threeandthreee
Copy link
Contributor

@threeandthreee threeandthreee commented Sep 20, 2024

What is this fixing or adding?

Extracts the improvements to Tarin's Gift from zig's entrance rando PR #1613 (with permission)

The gift is chosen based on reachable regions rather than an explicit list, and an option is provided to instead allow the gift to be any item.

Also added an option to start with something from the "Bush Breaker" group, so this pr is waiting on #3936 for the item groups.

How was this tested?

Generated, playtested, checked spoiler logs

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Sep 20, 2024
@Exempt-Medic Exempt-Medic added the is: enhancement Issues requesting new features or pull requests implementing new features. label Sep 20, 2024
@threeandthreee
Copy link
Contributor Author

Waiting on #3936 now, because I wanted to use the item group for new bush breakers setting, which was requested.

@Exempt-Medic
Copy link
Member

Why does this PR include #3936 ?

@threeandthreee
Copy link
Contributor Author

to use the bush breaker item group

Copy link

@SushiKishi SushiKishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allows for a lot more flexibility with your starting options, especially when combined with Open Mabe.  My seeds using this option have generated as expected.

Copy link
Contributor

@palex00 palex00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR was tested as part of a Beta apworld that was used in three dedicated Test Asyncs, as well as dozen of normal Syncs. I have also personally run 200 test generations which succeeded.

We have also done polling on what users want, etc. which can be found here

The new feature has worked as expected and other stuff does not seem impacted.

This also got additional stresstest in Vertraic's Custom Hyper Item Link which has very rough generation & strict logic and it worked flawlessly.

@Rooby-Roo
Copy link

Doing some test generations for my LinkLink games, which obligates the placement of basically every possible major progression item, which conflicts with Tarin's Gift by forcing all relevant items into a different world. A "beta" apworld that had this and several other PRs (thanks, Palex) is what I've been using. The option has been working seamlessly over a couple dozen test gens so far.

@Exempt-Medic Exempt-Medic added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jan 14, 2025
@Exempt-Medic Exempt-Medic added the waiting-on: author Issue/PR is waiting for feedback or changes from its author. label Jan 16, 2025
@threeandthreee
Copy link
Contributor Author

merge conflicts resolved

@Exempt-Medic Exempt-Medic removed the waiting-on: author Issue/PR is waiting for feedback or changes from its author. label Jan 16, 2025
@Exempt-Medic
Copy link
Member

This has conflicts

@Exempt-Medic Exempt-Medic added waiting-on: author Issue/PR is waiting for feedback or changes from its author. and removed waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. labels Feb 13, 2025
@threeandthreee
Copy link
Contributor Author

resolved

@Exempt-Medic Exempt-Medic added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: author Issue/PR is waiting for feedback or changes from its author. labels Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants