-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LADX: tarins gift improvement #3970
base: main
Are you sure you want to change the base?
LADX: tarins gift improvement #3970
Conversation
Waiting on #3936 now, because I wanted to use the item group for new bush breakers setting, which was requested. |
Why does this PR include #3936 ? |
to use the bush breaker item group |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Allows for a lot more flexibility with your starting options, especially when combined with Open Mabe. My seeds using this option have generated as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR was tested as part of a Beta apworld that was used in three dedicated Test Asyncs, as well as dozen of normal Syncs. I have also personally run 200 test generations which succeeded.
We have also done polling on what users want, etc. which can be found here
The new feature has worked as expected and other stuff does not seem impacted.
This also got additional stresstest in Vertraic's Custom Hyper Item Link which has very rough generation & strict logic and it worked flawlessly.
Doing some test generations for my LinkLink games, which obligates the placement of basically every possible major progression item, which conflicts with Tarin's Gift by forcing all relevant items into a different world. A "beta" apworld that had this and several other PRs (thanks, Palex) is what I've been using. The option has been working seamlessly over a couple dozen test gens so far. |
Co-authored-by: Exempt-Medic <[email protected]>
merge conflicts resolved |
This has conflicts |
resolved |
What is this fixing or adding?
Extracts the improvements to Tarin's Gift from zig's entrance rando PR #1613 (with permission)
The gift is chosen based on reachable regions rather than an explicit list, and an option is provided to instead allow the gift to be any item.
Also added an option to start with something from the "Bush Breaker" group, so this pr is waiting on #3936 for the item groups.
How was this tested?
Generated, playtested, checked spoiler logs