Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angel's Storage Options & Mass Transit fixes #1017

Open
wants to merge 4 commits into
base: dev2.0
Choose a base branch
from

Conversation

Aiving
Copy link

@Aiving Aiving commented Dec 2, 2024

PR is not very big, it makes these addons workable.

In Mass Transit it was enough to fix the update_equipment_grid function. (did not work well with mixed tables)

In Storage Options it was necessary to fix even less - only pipe_connections.

@pla
Copy link

pla commented Jan 12, 2025

I still get the following error in train-functions.lua, when loading masstransit
image

In your PR are only cosmetic (whitespace) changes in the file train-functions.lua

@pla
Copy link

pla commented Jan 12, 2025

storage mod gives me this error
image

both mods tested with only this one mod and debugger active on 2.0 latest

@Aiving
Copy link
Author

Aiving commented Jan 12, 2025

I still get the following error in train-functions.lua, when loading masstransit image

In your PR are only cosmetic (whitespace) changes in the file train-functions.lua

That's weird. The last time I tested this PR, there was no error.

@Aiving
Copy link
Author

Aiving commented Jan 12, 2025

Okay, I'll try to figure out what's wrong, but a little later. I'm going to bed now.

@Aiving
Copy link
Author

Aiving commented Jan 13, 2025

I still get the following error in train-functions.lua, when loading masstransit image

In your PR are only cosmetic (whitespace) changes in the file train-functions.lua

Do you happen to have a stack trace of the function call? That would help a lot in solving the problem

@Aiving
Copy link
Author

Aiving commented Jan 13, 2025

I still get the following error in train-functions.lua, when loading masstransit image
In your PR are only cosmetic (whitespace) changes in the file train-functions.lua

Do you happen to have a stack trace of the function call? That would help a lot in solving the problem

nvm, i think i've found where the error occurs

@Aiving
Copy link
Author

Aiving commented Jan 13, 2025

@pla try

@pla
Copy link

pla commented Jan 14, 2025

well I tried (and failed), but have you tried?

@Aiving
Copy link
Author

Aiving commented Jan 15, 2025

well I tried (and failed), but have you tried?

both mods not loading or just one? and no, i haven't tried those fixes (but i will as soon as i'm home!)

@Aiving
Copy link
Author

Aiving commented Jan 15, 2025

@pla everything is fixed and working (i tested!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants