Fix TARGET_APPIMAGE issues #128
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered two issues with
TARGET_APPIMAGEwhile working on #126:--appimage-helpis not working whenTARGET_APPIMAGEis used--appimage-portable-*is not working whenTARGET_APPIMAGEis usedBoth are due to
readlinkbeing used in different places without checking thatappimage_pathis a link.This PR fixes this by moving the code to get the full AppImage path up and adding a check to see whether
appimage_pathis a link.