Skip to content

Create vlc-3.0.0 #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Create vlc-3.0.0 #434

wants to merge 1 commit into from

Conversation

anupam-git
Copy link
Contributor

No description provided.

@probonopd
Copy link
Member

Hi @anupam-git thanks for your PR. I am not entirely sure what is going on here, but I suspect that VLC is being launched without a GUI:

VLC media player 3.0.0 Vetinari (revision 3.0.0-30-gef4c265336)
Parent is shutting down, bye...
AppImage unmounted
NUMBER_OF_WINDOWS: 0
ERROR: Could not find a single window on screen :-(

Can you modify the AppImage so that GUI is launched at all times? (E.g., qvlc rather than vlc?)

@anupam-git
Copy link
Contributor Author

anupam-git commented Mar 6, 2018

@probonopd
Running the qt interface by default will affect the way vlc command works.
vlc chooses the interface automatically.

So running vlc.AppImage -Iqt will run the QT Interface for all cases but for users who would want to run vlc from shell will not be able to use the appimage..

image

Isn't there any other approach to fix this ??

@probonopd
Copy link
Member

vlc chooses the interface automatically.

Do you know how this works?

@anupam-git
Copy link
Contributor Author

No.. Let me try to find it out..

@anupam-git
Copy link
Contributor Author

https://github.com/videolan/vlc/blob/master/bin/vlc.c#L232
Seems that is being done by libvlc, and not vlc

https://github.com/videolan/vlc/blob/694399e23000232708b2d514a6a265cfc023ddde/src/interface/interface.c#L212
From here it is clear that if no interface is passed as argument then "default" interface is ran which in turn falls back to supported interface if default fails.

And if any specific interface is passed, it does not run the "default" interface(because of the NULL check) if that specified interface fails..

@anupam-git
Copy link
Contributor Author

Also found out that on linux, QT is the default interface and in mac macosx is the default interface

@probonopd
Copy link
Member

Do you have any idea why the Qt interface is apparently not being run in our CI test? Is there a way to enforce Qt to be used?

@anupam-git
Copy link
Contributor Author

No idea regarding that.. What I can do is that I can manually run the tests you are running to debug the error..

@probonopd
Copy link
Member

Does anyone know how VLC decides when to use Qt?

@anupam-git
Copy link
Contributor Author

VLC Runs the default interface everytime it is ran..
If the default interface fails, then a fallback interface is ran which is the CLI interface..

In case of linux the default interface is QT..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants