pandora: sync code with the latest version of https://github.com/HesaiTechnology/Pandora_ros #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't use the Pandora's cameras with the driver currently provided by apollo-contrib.
I simply copied the latest version of each file in the Pandora_ros driver provided by HesaiTechnology and got the cameras working.
For now, this PR contains a simple copy of the code of HesaiTechnology. However, I noticed it introduces some regressions (such as typos which had been fixed by Baidu, like deconstructor/destructor) Should I just let those typos in to make it easier in the future to sync the driver with the code of HesaiTechnology? Should I fix them all and only keep code changes? If you want changes from the code distributed by HESAI, then what else would you want?