Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Server Favourite #9717

Merged
merged 4 commits into from
Feb 10, 2025
Merged

Add Server Favourite #9717

merged 4 commits into from
Feb 10, 2025

Conversation

Atomic-Laboratory
Copy link
Contributor

@Atomic-Laboratory Atomic-Laboratory commented Apr 7, 2024

If your pull request is not translation or serverlist-related, read the list of requirements below and check each box:

  • I have read the contribution guidelines.
  • I have ensured that my code compiles, if applicable.
  • [?] I have ensured that any new features in this PR function correctly in-game, if applicable.

What it would look like if accepted.
image

Things that may cause this PR to be not accepted:

  1. If doInit is changed to false, so the server name bar doesn't appear if servers are offline, there is strange behavior when there are more than 1 sever in a server group.
    image
    Works fine if there is only 1 server, or if doInit is true.

  2. There is no tool-tip describing what the star button does (for accessibility?)

I ask anyone who is knowledgeable to help me with this PR, I'm trying my best 😭

I'm trying to add a feature while barely knowing what I'm doing...
@Atomic-Laboratory
Copy link
Contributor Author

doInit should be false to prevent things like this from happening
image

@Anuken Anuken merged commit 3bdb871 into Anuken:master Feb 10, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants