Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data imported exit message #9692

Closed
wants to merge 2 commits into from

Conversation

SITUVNgcd
Copy link
Contributor

This will make players less confusing after game's data imported and no message tell them. They will think that is a crash.

  • I have read the contribution guidelines.
  • I have ensured that my code compiles, if applicable.
  • I have ensured that any new features in this PR function correctly in-game, if applicable.

@Anuken
Copy link
Owner

Anuken commented Feb 4, 2025

The reason no message is displayed is that I am concerned that cached data (say, sector information) can overwrite the existing data file while the dialog is open. This needs rigorous testing.

@Anuken Anuken closed this Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants