Improve SyncI #8891
Closed
Improve SyncI #8891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe just at most once pre tick? |
what do you think this does |
3 tasks
|
stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
This PR increases the sync rate from 10 times per second (100ms) to 66.6 times per second (15ms).
why
You might want to sync some things a lot faster for precision (or other networking-related) reasons. However, there's no real point to synchronize anything faster than once every tick, because the vast majority of Mindustry players run at 60 FPS, and synchronizing a variable faster than that is wasteful. It also isn't a multiple-orders-of-magnitude level increase, your code would have to intentionally be bad (from a mapper PoV) in order for problems to occur.
I chose 15ms because it allows some more leeway with frametimes.
what's the worst that can happen
Bandwidth might increase up to 6x for badly written code. Not really within crashing limits, but still probably on the same importance as
setblockandexplosionspam (tested just now on a statistically average client-server pair)If your pull request is not translation or serverlist-related, read the list of requirements below and check each box: