@printbuffer #10499
Open
@printbuffer #10499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
way-zer
reviewed
Feb 14, 2025
| @@ -62,7 +62,7 @@ public class LExecutor{ | |||
| //yes, this is a minor memory leak, but it's probably not significant enough to matter | |||
| protected static IntFloatMap unitTimeouts = new IntFloatMap(); | |||
| //lookup variable by name, lazy init. | |||
| protected @Nullable ObjectIntMap<String> nameMap; | |||
| protected @Nullable ObjectIntMap<CharSequence> nameMap; | |||
There was a problem hiding this comment.
HashMap should use immutable class(String) as key.
| } | ||
|
|
||
| //region utility | ||
|
|
||
|
|
||
| public @Nullable LVar optionalVar(String name){ | ||
| public @Nullable LVar optionalVar(CharSequence name){ |
There was a problem hiding this comment.
Did you test this? Query with StringBuilder but String in Map.
There was a problem hiding this comment.
gonna test it in a few hours
There was a problem hiding this comment.
i found a solution but cant fix it yet (nother 2 hours or so)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a reference to the print buffer to processors (
@printbuffer), and also changes some behaviours to allow stringbuilders to be used in logic.If your pull request is not translation or serverlist-related, read the list of requirements below and check each box: