Mining beam weapon #10483
Merged
Mining beam weapon #10483
+86
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idk if it matters if name is null, but just in case
Anuken
reviewed
Feb 9, 2025
|
ehe... |
Anuken
reviewed
Feb 9, 2025
| float ex = unit.mineTile.worldx() + Mathf.sin(Time.time + 48, swingScl, swingMag); | ||
| float ey = unit.mineTile.worldy() + Mathf.sin(Time.time + 48, swingScl + 2f, swingMag); | ||
|
|
||
| Draw.z(Layer.flyingUnit + 0.1f); | ||
|
|
||
| Draw.color(Color.lightGray, Color.white, 1f - flashScl + Mathf.absin(Time.time, 0.5f, flashScl)); | ||
|
|
||
| Draw.alpha(Renderer.unitLaserOpacity); | ||
| Drawf.laser(mineLaserRegion, mineLaserEndRegion, px, py, ex, ey, 0.75f); | ||
| Drawf.laser(Core.atlas.find("minelaser"), Core.atlas.find("minelaser-end"), px, py, ex, ey, 0.75f); |
There was a problem hiding this comment.
Is this accidental? You've removed the opacity code that you added a setting for, and the proper region usage too.
There was a problem hiding this comment.
Copied code from the old PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #8422.
Gives the mining beam consistency with build beam with:
If your pull request is not translation or serverlist-related, read the list of requirements below and check each box: