Fix: zephyr reranker returns list when single result expected #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When using Zephyr from RankLLM, it returns a list of results (because it calls
rerank_batch
with a single item).Naturally, it's not expected behaviour, and the
rerankers
crash with an errorChanges
We check if we got a list, and if so, unwrap it.
Sending a PR to upstream might be more difficult because it will be a breaking change there.
Testing
Zephyr
reranker from RankLLM works after fixing this issue.