Migrate legacy notebooks in shared readers - #56
Draft
PiotrCzapla wants to merge 2 commits into
Draft
Conversation
Contributor
|
This is way too heavyweight for a one-time change. Perhaps a little standalone script is better for those that need it? |
Contributor
|
Remember the fundamental principle: all code is tech debt. So it must earn its place! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old CRAFT notebooks could supply an AI reply containing a tool call as ordinary text. The model could copy that example instead of calling a tool.
Notebook readers now normalize text to strings before applying migrations from v1 through v3. The migrations convert old metadata, markdown prompts, and tool calls stored in
<details>blocks. Writers usenb2strto restore lists of lines on disk.Reading preserves the source file and attachments. The
migrated_attribute records whether the dialog needs saving. A successful save clears it. Writers always use v3 and no longer accept aversionargument.Validation: all aidialog notebooks pass. The examples check tool calls, attachments, unchanged CRAFT files, repeated saves, and rejection of unsupported versions.
Companion: Solveit #1942.