Merge pull request #43 from AnswerDotAI/Navbar-improvement

Improve defaults for Navbar when text is passed
AnswerDotAI · Jan 31, 2025 · b33df11 · b33df11
2 parents 33903a9 + 0c3a07a
commit b33df11
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/monsterui/franken.py b/monsterui/franken.py
@@ -1192,7 +1192,7 @@ def _item(link):
     return Div(
         Container(
             Div(cls='md:flex md:relative')(
-                NavBarLSide(H1(title), menu_icon),
+                NavBarLSide(H1(title) if isinstance(title, str) else title, menu_icon),
                 NavBarRSide(
                     NavBarNav(*nav_links, cls='w-full flex-col md:flex-row'),
                     cls='hidden md:flex md:justify-between ',  id=_id, uk_scrollspy_nav=_uk_scrollspy_nav, **kwargs))),
@@ -1318,8 +1318,8 @@ def CardContainer(*c, # Components (typically `CardHeader`, `CardBody`, `CardFoo
 
 # %% ../nbs/02_franken.ipynb
 def Card(*c, # Components that go in the body (Main content of the card such as a form, and image, a signin form, etc.)
-        header=None, # A component that goes in the header (often a `ModalTitle` and description)
-        footer=None,  # A component that goes in the footer (often a `ModalCloseButton`)
+        header:FT|Iterable[FT]=None, # Component(s) that goes in the header (often a `ModalTitle` and a subtitle)
+        footer:FT|Iterable[FT]=None,  # Component(s) that goes in the footer (often a `ModalCloseButton`)
         body_cls='space-y-6', # classes for the body
         header_cls=(), # classes for the header
         footer_cls=(), # classes for the footer

diff --git a/nbs/02_franken.ipynb b/nbs/02_franken.ipynb
@@ -2120,7 +2120,7 @@
     "    return Div(\n",
     "        Container(\n",
     "            Div(cls='md:flex md:relative')(\n",
-    "                NavBarLSide(H1(title), menu_icon),\n",
+    "                NavBarLSide(H1(title) if isinstance(title, str) else title, menu_icon),\n",
     "                NavBarRSide(\n",
     "                    NavBarNav(*nav_links, cls='w-full flex-col md:flex-row'),\n",
     "                    cls='hidden md:flex md:justify-between ',  id=_id, uk_scrollspy_nav=_uk_scrollspy_nav, **kwargs))),\n",
@@ -2382,8 +2382,8 @@
    "source": [
     "#|export\n",
     "def Card(*c, # Components that go in the body (Main content of the card such as a form, and image, a signin form, etc.)\n",
-    "        header=None, # A component that goes in the header (often a `ModalTitle` and description)\n",
-    "        footer=None,  # A component that goes in the footer (often a `ModalCloseButton`)\n",
+    "        header:FT|Iterable[FT]=None, # Component(s) that goes in the header (often a `ModalTitle` and a subtitle)\n",
+    "        footer:FT|Iterable[FT]=None,  # Component(s) that goes in the footer (often a `ModalCloseButton`)\n",
     "        body_cls='space-y-6', # classes for the body\n",
     "        header_cls=(), # classes for the header\n",
     "        footer_cls=(), # classes for the footer\n",