doc: Clarify branching after Eigen discussion #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
I cannot assign but @cst0 @malban please review this PR along with #33 (comment). |
malban
reviewed
Aug 16, 2022
| [branch]: https://github.com/AndreaCensi/csm/tree/csm_eigen | ||
| - Main, development branch: [`master`][branch]. Note this uses `GSL`, which is licensed as GPL as of 2022/08. | ||
| - Another development branch: [`master_eigen`][branch]. This uses license permissible library `eigen`, instead of GSL. | ||
| - As of 2022/08/15, this branch is behind `master`. Cherry-picking effort for the newer changes that are only merged into `master` is appreciated. |
There was a problem hiding this comment.
I think I went through and looked at the differences between csm_eigen and master and only found the sm_icp_xy function to be missing, which has since been added to bring the branches into parity.
I see a few build related commits to the master branch only which I think are taken care of with #34.
So they should currently be at parity, but I agree with the comment that new changes should get cherry picked to both branches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #33, a new direction to use Eigen is discussed for longer maintenance purpose. This PR attempts to update and clarify branching policy.