Add missing feature macros #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using some functions (like strdup) without defining the required feature macros. For instance, strdup requires `_POSIX_C_SOURCE >= 200809L`, and vasprintf _GNU_SOURCE. This was causing some SEGFAULT because the functions were assumed to have the signature `int f()`. Fix this by defining `_DEFAULT_SOURCE` (which defines `_POSIX_C_SOURCE >= 200809L`) and _GNU_SOURCE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using some functions (like strdup) without defining the required feature
macros. For instance, strdup requires
_POSIX_C_SOURCE >= 200809L, andvasprintf _GNU_SOURCE. This was causing some SEGFAULT because the functions were
assumed to have the signature
int f(), but returned something of a different size (as strdup).Fix this by defining
_DEFAULT_SOURCE(which defines_POSIX_C_SOURCE >= 200809L) and_GNU_SOURCE.Note: this should not impact the system that doesn't have the impacted functions for the functions we check with
CHECK_FUNCTION_EXISTS.