query shows poll status in progress while cast vote errors with not i… #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys, I Found this issue while copying your code to terra-vegas casino
This issue is a confusing query issue in the governance contract.
The confusion happens in this line
https://github.com/Anchor-Protocol/anchor-token-contracts/blob/main/contracts/gov/src/contract.rs#L598
This happens when the voting period is finished but no tx has happened yet.
This could be mitigated by adding a new condition on the query function to make sure we send the right response.
I put the Status to Expired because I did not want to add a new PollStatus::WaitingOnTransactionToEndPoll. But I believer a new status should be there to better describe the Poll status