[Feature] Add Support for Human-Readable Data Units in NVMe Attributes #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StancuFlorin
force-pushed
the
transformed_with_unit
branch
from
6beab8e to
ccd0feb
Compare
StancuFlorin
changed the title
StancuFlorin
force-pushed
the
transformed_with_unit
branch
from
ccd0feb to
9b8140a
Compare
StancuFlorin
force-pushed
the
transformed_with_unit
branch
from
6cffb42 to
8b34dfc
Compare
StancuFlorin
changed the title
|
@AnalogJ - can you please take a look on this one? thanks! |
|
Hey @StancuFlorin my concern is that the raw data structure is not standardized across device manufacturers, so I'm worried that this may be incorrect for some users. |
|
@AnalogJ - I also considered this. However, the formula used to display the human readable data is the one from the attribute description (the one displayed on the left). Additionally, you can still view the RAW data in the normalized field, in case the formula is wrong. |
|
@AnalogJ - any second thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds support for displaying transformed values with appropriate units for NVMe drive attributes. This enhancement improves the readability of large data values by converting them to appropriate units (MB, GB, TB, PB) based on their size.
Changes
Backend Changes
TransformDataUnitsutility function insmart_utils.gothat converts raw data values (in 512-byte units) to appropriate human-readable unitsSmartNvmeAttributestruct to include a newValueUnitfield to store the unit type (MB, GB, TB, PB)transformed_with_unitfor attributes that should use this transformationdata_units_readanddata_units_writtenFrontend Changes
Screenshots
Old Implementation
New Implementation
Related Issues
Notes
Unfortunately, the data is returned as int64 instead of float64, preventing me from displaying decimals. This is due to the existing
TransformedValuefield, which is of type int64.