Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dialog): background color of dialogs #583

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

marfavi
Copy link
Member

@marfavi marfavi commented Dec 3, 2024

On iOS the background color of dialogs are ignored when calling showAdaptiveDialog. Instead, calling showDialog creates a Material dialog which enforces the background/"barrier" color.

@marfavi marfavi enabled auto-merge (squash) December 3, 2024 18:15
Copy link
Contributor

@Slug-Boi Slug-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Saw you running the app next to me 👍🏻

@marfavi marfavi merged commit c80e4eb into main Dec 3, 2024
8 checks passed
@marfavi marfavi deleted the dialog-background branch December 3, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants