Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes two significant changes to the operator helm chart
release process:
helm.altinity.com when new releases are created. (NB: The release
name must match the release tag or the release workflow will fail)
altinity-clickhouse-operator
toclickhouse-operator
which is cleaner when next to a repo namedaltinity
.Because of the way that Chart Releaser works, only new releases are
merged with the existing helm index.yaml from helm.altinity.com.
For the new workflow to work:
HELM_GITHUB_REPOSITORY
must exist and point tothe
helm-charts
repository.HELM_GITHUB_TOKEN
must exist and contain a GitHubPAT with read/write permissions on the
helm-charts
repository.Important items to consider before making a Pull Request
Please check items PR complies to:
next-release
branch, not intomaster
branch1. More info--
1 If you feel your PR does not affect any Go-code or any testable functionality (for example, PR contains docs only or supplementary materials), PR can be made into
master
branch, but it has to be confirmed by project's maintainer.