Skip to content

Backport of #86414 Fail when all replicas are unavailable for *cluster functions #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2025
Merged

Backport of #86414 Fail when all replicas are unavailable for *cluster functions #993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fa864a
Fail when all replicas are unavailable for *cluster functions
jmaicher Aug 29, 2025
0a347b6
Merge branch 'antalya-25.6.5' into backport/antalya-25.6.5/86414
Enmk Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/Storages/IStorageCluster.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,11 @@ namespace ErrorCodes
extern const int NOT_IMPLEMENTED;
}

namespace ErrorCodes
{
extern const int ALL_CONNECTION_TRIES_FAILED;
}

IStorageCluster::IStorageCluster(
const String & cluster_name_,
const StorageID & table_id_,
Expand Down Expand Up @@ -293,10 +298,10 @@ void ReadFromCluster::initializePipeline(QueryPipelineBuilder & pipeline, const
pipes.emplace_back(std::move(pipe));
}

auto pipe = Pipe::unitePipes(std::move(pipes));
if (pipe.empty())
pipe = Pipe(std::make_shared<NullSource>(getOutputHeader()));
if (pipes.empty())
throw Exception(ErrorCodes::ALL_CONNECTION_TRIES_FAILED, "Cannot connect to any replica for query execution");

auto pipe = Pipe::unitePipes(std::move(pipes));
for (const auto & processor : pipe.getProcessors())
processors.emplace_back(processor);

Expand Down
14 changes: 14 additions & 0 deletions tests/config/config.d/clusters.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,5 +325,19 @@
</replica>
</shard>
</test_shard_bind_host_fail>
<test_cluster_multiple_nodes_all_unavailable>
<node>
<host>127.0.0.1</host>
<port>1234</port>
</node>
<node>
<host>127.0.0.2</host>
<port>1234</port>
</node>
<node>
<host>127.0.0.3</host>
<port>1234</port>
</node>
</test_cluster_multiple_nodes_all_unavailable>
</remote_servers>
</clickhouse>
Empty file added tests/queries/0_stateless/03603_reading_s3_cluster_all_nodes_unavailable.reference
View file
Open in desktop
Empty file.
4 changes: 4 additions & 0 deletions tests/queries/0_stateless/03603_reading_s3_cluster_all_nodes_unavailable.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
-- Tags: no-fasttest
-- s3Cluster is not used in fast tests

SELECT * FROM s3Cluster('test_cluster_multiple_nodes_all_unavailable', 'http://localhost:11111/test/a.tsv'); -- { serverError ALL_CONNECTION_TRIES_FAILED }
Loading