Skip to content

25.6 Pipeline cleanup #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

25.6 Pipeline cleanup #925

wants to merge 10 commits into from

Conversation

strtgbb
Copy link
Collaborator

@strtgbb strtgbb commented Jul 21, 2025 •
edited
Loading

Changelog category (leave one):

  • CI Fix or Improvement (changelog entry is not required)

Tasks

  • Remove fast test (same issues as stateless)
  • Remove performance test (doesn’t support GH secrets)
  • Fix or remove fuzzers
  • Try natively compiling arm asan, or remove it
  • Reduce parallelism in integration jobs to avoid crash

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • All Regression
  • Disable CI Cache

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 21, 2025 •
edited
Loading

Workflow [PR], commit [e0b3a9a]

@strtgbb strtgbb added cicd Improvements and fixes to the CICD process antalya-25.6 labels Jul 21, 2025
@strtgbb strtgbb force-pushed the pipeline-cleanup-25.6 branch 2 times, most recently from 6443962 to 3578694 Compare July 21, 2025 20:00
@zvonand
Copy link
Collaborator

zvonand commented Jul 22, 2025

Why are all these sanitizers tests are run (and failed) despite marked as excluded in PR description?

@strtgbb
Copy link
Collaborator Author

strtgbb commented Jul 22, 2025

Upstream changed the way tests are excluded, the old system no longer works, although I did find a hack for regression. I still need to investigate how upstream is excluding tests now.

@strtgbb strtgbb force-pushed the pipeline-cleanup-25.6 branch 4 times, most recently from e00f7dd to f0436de Compare July 22, 2025 18:09
@strtgbb strtgbb force-pushed the pipeline-cleanup-25.6 branch from f0436de to de3e358 Compare July 22, 2025 19:05
@strtgbb strtgbb requested a review from zvonand July 22, 2025 20:38
@strtgbb strtgbb force-pushed the pipeline-cleanup-25.6 branch from 7079c5b to e0b3a9a Compare July 23, 2025 19:30
@strtgbb strtgbb requested a review from arthurpassos July 24, 2025 03:22
arthurpassos
arthurpassos reviewed Jul 24, 2025
View reviewed changes
Copy link
Collaborator

@arthurpassos arthurpassos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's 2~3 years since I dealt with CICD code, my understanding is kind of limited. Sorry for the superficial review.

.github/workflows/master.yml
@@ -202,47 +202,6 @@ jobs:
python3 -m praktika run 'Dockers Build (multiplatform manifest)' --workflow "MasterCI" --ci |& tee ./ci/tmp/job.log
fi

fast_test:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this being removed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was added in a previous PR for debugging purposes. The issues seem to be the same as with stateless, so there is no need to keep it here.

.github/actions/runner_setup/action.yml
@@ -16,5 +16,4 @@ runs:
- name: Install awscli
shell: bash
run: |
.github/retry.sh 3 10 sudo apt-get update
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the update?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It triggered an auto-update, which occasionally caused the setup step to fail. I have addressed this on the runner side, so this change could be reverted.

.github/workflows/pull_request.yml
fi

upgrade_check_amd_debug:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this being removed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not configured correctly for our repo. I can be re-enabled and configured in a seperate PR.

.github/workflows/pull_request.yml
@@ -4299,421 +4094,11 @@ jobs:
. ./ci/tmp/praktika_setup_env.sh
set -o pipefail
if command -v ts &> /dev/null; then
python3 -m praktika run 'BuzzHouse (amd_debug)' --workflow "PR" --ci |& ts '[%Y-%m-%d %H:%M:%S]' | tee ./ci/tmp/job.log
else
python3 -m praktika run 'BuzzHouse (amd_debug)' --workflow "PR" --ci |& tee ./ci/tmp/job.log
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the else? As I understand, the if statement checks if ts is available and does something else if not.

Do I get it right that if ts isn't available you don't want to do anything?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is auto-generated, and the github diff is misleading.

zvonand
zvonand approved these changes Jul 25, 2025
View reviewed changes
.github/workflows/release_branches.yml
@@ -448,47 +448,6 @@ jobs:
python3 -m praktika run 'Build (arm_release)' --workflow "ReleaseBranchCI" --ci |& tee ./ci/tmp/job.log
fi

build_arm_asan:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, we are removing some builds with sanitizers? Why?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only use x86 builders and the ARM ASAN build is very difficult to cross-compile.

@strtgbb
Copy link
Collaborator Author

strtgbb commented Jul 25, 2025

merged into antalya-25.6.5

@strtgbb strtgbb closed this Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthurpassos arthurpassos arthurpassos approved these changes

@zvonand zvonand zvonand approved these changes

Assignees
No one assigned
Labels
antalya-25.6 cicd Improvements and fixes to the CICD process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@strtgbb @zvonand @arthurpassos