Skip to content

Conversation

@pianohacker
Copy link

Closes #7.

@pianohacker
Copy link
Author

@AltSysrq , this does most of what we described. There's three main issues with it:

  1. There's file mode changes in the output I don't quite understand.
  2. Many error messages that cause the sync to completely fail end up as panics. Is the solution to this to convert all of these to calls to a method on the LoggerImpl objects? That might be a good followup PR.
  3. Most of the specific subtypes of conflict log messages don't appear in the log output. This matters more for completeness than my desired use case.

Copy link
Owner

@AltSysrq AltSysrq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's file mode changes in the output I don't quite understand.

Can you elaborate?

panics … LoggerImpl

I didn't think there were any non-catastrophic situations where the exitsing code would panic like that, and I didn't see any situations where your new code would cause that?

Most of the specific subtypes of conflict log messages don't appear in the log output.

I'm fine with saying YAGNI on this.

@pianohacker
Copy link
Author

There's file mode changes in the output I don't quite understand.

Can you elaborate?

e.g., at line of 335 of test/previous-outputs/1.0.1.json, there's a mode change from 384 to 33152.

panics … LoggerImpl

I didn't think there were any non-catastrophic situations where the exitsing code would panic like that, and I didn't see any situations where your new code would cause that?

Hm, taking a second look, not panics, but things that are returned as errors rather than being logged. This applies to most of the errors from run_sync().

@AltSysrq
Copy link
Owner

AltSysrq commented Oct 4, 2022

e.g., at line of 335 of test/previous-outputs/1.0.1.json, there's a mode change from 384 to 33152.

That was actually a bug in ensync put where it failed to mask off the non-permission mode bits. I fixed it on master.

@AltSysrq
Copy link
Owner

AltSysrq commented Oct 4, 2022

things that are returned as errors rather than being logged. This applies to most of the errors from run_sync()

Could that just be handled specially here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposal: JSON status output for ensync sync

2 participants