-
Notifications
You must be signed in to change notification settings - Fork 2
Add optional JSON status output #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@AltSysrq , this does most of what we described. There's three main issues with it:
|
AltSysrq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's file mode changes in the output I don't quite understand.
Can you elaborate?
panics …
LoggerImpl
I didn't think there were any non-catastrophic situations where the exitsing code would panic like that, and I didn't see any situations where your new code would cause that?
Most of the specific subtypes of conflict log messages don't appear in the log output.
I'm fine with saying YAGNI on this.
Co-authored-by: Jason Lingle <[email protected]>
e.g., at line of 335 of test/previous-outputs/1.0.1.json, there's a mode change from 384 to 33152.
Hm, taking a second look, not panics, but things that are returned as errors rather than being logged. This applies to most of the errors from |
That was actually a bug in |
Could that just be handled specially here? |
Closes #7.