Skip to content

Conversation

@luke-clifton
Copy link

  • Tested on an x11 machine
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • cargo doc builds successfully
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes
  • Created or updated an example program if it would help users understand this functionality

I have a use case where I want to run X11 applications on Darwin (using Xquartz). I've tested this change on Linux and MacOS.

I didn't introduce a conditional here, though I can if that is preferred, just let me know.

I did not run cargo fmt on this branch because it made changes elsewhere in the code. The part I added is unchanged by cargo fmt.

@luke-clifton
Copy link
Author

Sorry, meant to mention, I will add the dylibs to all the loading paths if this approach is acceptable.

@luke-clifton luke-clifton force-pushed the darwin-x11 branch 3 times, most recently from 248e718 to cf702b7 Compare June 16, 2023 13:42
@AltF02 AltF02 self-assigned this Aug 1, 2023
@AltF02
Copy link
Owner

AltF02 commented Aug 1, 2023

Apologies for my absence, unfortunately I'm unable to test Darwin.

Maybe an idea to use the cfg attribute? E.g. #[cfg(target_os = "macos")]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants