-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rearchitecture backend #193
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
…REPL-backend into rearchitecture_backend
so arepl frontend can use both files
note i preserved some python 3.8 compatability
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Nov 19, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Almenon/AREPL-vscode#439. This PR ended up being different than my original concept.
I went with three executors. Each executor has the following lifecycle
When
execCode
is called, code will always go to a executor in the FreshFree status, so it may execute without side effects. It's possible no executor is fresh, so when new code comes in if there are dirty or executing executors they will be restarted. If no executors are in fresh status, we will wait for an executor to reach that status.I also have a
execCodeCurrent
function, as one may be okay with side effects and want to reuse the current executor.I tried to keep the API of
PythonExecutors
similar to the original class to minimize refactoring.An example of how AREPL works now (assuming two executors, we use three but same principle applies):
At each point between 1. 2. and 3. there will be at minimum a delay of the debounce period, which is usually fast enough to make things seem snappy.
As a consequence of this change I was able to drop 108 lines of logic from
arepl_python_evaluator.py
. Pretty satisfying.Unrelated to #439: