Skip to content

Finish behavior agnostic PR for the SDK #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jeromelecoq opened this issue Oct 10, 2022 · 8 comments
Closed

Finish behavior agnostic PR for the SDK #37

jeromelecoq opened this issue Oct 10, 2022 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@jeromelecoq
Copy link
Collaborator

jeromelecoq commented Oct 10, 2022

Ahad to add description here

@jeromelecoq
Copy link
Collaborator Author

Once your have understood 2p raw data addition. Perhaps making a new PR for this would be good.

@jeromelecoq
Copy link
Collaborator Author

@Ahad-Allen to talk to Adam about this.

@Ahad-Allen
Copy link
Collaborator

I've messaged Adam about his suggestions for the best way to handle the PR and which branch to merge into.

@Ahad-Allen
Copy link
Collaborator

Adam responded by suggesting that the best way to handle this is attempting to merge my branch into main. it is likely that there will be merge conflicts doing so, but he is willing to dedicate some time to help me clear those.

@Ahad-Allen
Copy link
Collaborator

Created a PR here AllenInstitute/AllenSDK#2664. Per the allenSDK's guidelines there will be some minor changes I need to implement (Mostly creating a unit test for the non-behavior ophys session), and I will need Adam's help with some merge conflicts. I will update this ticket based on the results of that. Additionally, I think we will need to try converting a behavior-based ophys session to make sure none of my changes are breaking

@jeromelecoq
Copy link
Collaborator Author

Ahad to ask status on this to the team. Whether they still plan to rewrite

@Ahad-Allen
Copy link
Collaborator

Contacted the team and was informed a rewrite is still in the backlog

@jeromelecoq
Copy link
Collaborator Author

This will not be merged so closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants