-
Notifications
You must be signed in to change notification settings - Fork 0
Finish behavior agnostic PR for the SDK #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Once your have understood 2p raw data addition. Perhaps making a new PR for this would be good. |
@Ahad-Allen to talk to Adam about this. |
I've messaged Adam about his suggestions for the best way to handle the PR and which branch to merge into. |
Adam responded by suggesting that the best way to handle this is attempting to merge my branch into main. it is likely that there will be merge conflicts doing so, but he is willing to dedicate some time to help me clear those. |
Created a PR here AllenInstitute/AllenSDK#2664. Per the allenSDK's guidelines there will be some minor changes I need to implement (Mostly creating a unit test for the non-behavior ophys session), and I will need Adam's help with some merge conflicts. I will update this ticket based on the results of that. Additionally, I think we will need to try converting a behavior-based ophys session to make sure none of my changes are breaking |
Ahad to ask status on this to the team. Whether they still plan to rewrite |
Contacted the team and was informed a rewrite is still in the backlog |
This will not be merged so closing |
Uh oh!
There was an error while loading. Please reload this page.
Ahad to add description here
The text was updated successfully, but these errors were encountered: