Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): fix public github repo cannot be selected #6680

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

xyeric
Copy link
Contributor

@xyeric xyeric commented Feb 11, 2025

Current behavior:

Public Github repo cannot be selected.

image

Cause analysis:

In file github-repo-selector.tsx,the original intention of this line L34 perhaps to deduplicate two lists, but public repo list has filtered with it self, causing the selected repo cannot be matched in the select event hander.

image

Proposed solution

filter public repo list with user repo list.

image

Copy link
Collaborator

@tofarr tofarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰 - Good catch. Making sure that the public repos are not in the user repo list - rather than in itself

@xingyaoww xingyaoww enabled auto-merge (squash) February 11, 2025 16:18
@rbren
Copy link
Collaborator

rbren commented Feb 11, 2025

🤦 this was my fault. thank you!

@xingyaoww xingyaoww merged commit 6772227 into All-Hands-AI:main Feb 11, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants