-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement]: Handle GH token refresh inside runtime #6632
Open
malhotra5
wants to merge
9
commits into
main
Choose a base branch
from
runtime-refresh
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+82
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xingyaoww
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
status_callback=self._status_callback, | ||
headless_mode=False, | ||
env_vars=env_vars, | ||
user_id=self.user_id, # Pass user id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe we could just do:
kwargs = {}
if runtime_cls == RemoteRuntime:
kwargs['user_id'] = self.user_id
And then pass **kwargs
in runtime_cls
constructor to reduce some code duplication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End-user friendly description of the problem this fixes or functionality that this introduces
Give a summary of what the PR does, explaining any non-trivial design decisions
The GH token can expire inside the runtime (either during the session or when returning to one after a long time). This PR does the following for remote runtimes only
CmdRunActions
that are attempting to use$GITHUB_TOKEN
export GITHUB_TOKEN={token}
where the token is fetched fromGitHubService
(this diff explains this exact behavior)This ensures that the latest Github token has been exported to the env BEFORE any Github API request is executed by the agent
Link of any specific issues this addresses
To run this PR locally, use the following command: