-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(SaaS): Billing settings screen #6495
Conversation
amount, | ||
}, | ||
); | ||
return data.redirect_url; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should issue a 302 redirect from the backend for this... 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Not a blocker though)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would agree, the only thing is that when testing/mocking, msw
cannot actually simulate a redirect. This means that when running the FE with e.g., npm run dev:mock:saas
, we won't redirect to the test Stripe form.
Not a big deal, technically you can still copy-paste the 302 redirect URL from the network tab when in a mocked env.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can trim down the tests slightly, as some of the constraints there are no longer applicable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍰
/settings/billing
screen and payment form/settings
route and fix stylesdev:mock:saas
start script to (semi-)simulate a saas environment for the FE onlycreateCheckoutSession
to initiate a paymentgetBalance
to get the user's balance<SettingsInput />
componentonChange
propmsw
To run this PR locally, use the following command: