Bug fixes #6460
Bug fixes #6460
Conversation
- Added sandbox.docker_snapshots config (bool) - Mounts a btrfs loop device for docker storage - Can be enabled/disabled (revert docker config change)
This reverts commit 97465c6.
And increased timeout, needed for slow headless docker in docker environments.
| @@ -0,0 +1 @@ | |||
| The files in this directory configure a development container that can be used for development on Windows using Microsoft's "Dev Containers" extension for VS Code. | |||
There was a problem hiding this comment.
Didn't we already have something like this before but we removed it because it was yet another way to run OpenHands that is not fully supported?
By adding extra ways to run OH, we need them to be maintained and I'm not sure if the current maintainers will want to maintain another way. Unless you add a note that says "This is not officially supported and may not work".
I'll let people like @enyst comment.
There was a problem hiding this comment.
Yes, that's correct. The team decided not to support DevContainer.
I tried the official documentation, but it didn’t work on Windows probably because it requieres you too install a Linux WSL distro + tools on top of WSL. Probably not difficult, but I expected easy instructions to start out of the box, and DevContainers helped here.
DevContainer is simply a definition that specifies which Linux environment to create to make it easier to start developing and debugging OH, especially in Windows. You just open VS Code and it starts the container. When you close VS Code, the container is automatically stopped. You can also start the container manually outside VS Code. It's very simple and handy.
That said, I’m happy to give it support and make it an easier UX for new developers.
Please let me know if you want any further refinements!
| self.api_url = f'{self.config.sandbox.local_runtime_url}:{self._container_port}' | ||
| self.log( | ||
| 'debug', | ||
| f'attached to container: {self.container_name} {self._container_port} {self.api_url}', | ||
| ) | ||
|
|
||
| @tenacity.retry( | ||
| stop=tenacity.stop_after_delay(120) | stop_if_should_exit(), | ||
| stop=tenacity.stop_after_delay(300) | stop_if_should_exit(), |
There was a problem hiding this comment.
why did this increase?
| stop=tenacity.stop_after_delay(300) | stop_if_should_exit(), | |
| stop=tenacity.stop_after_delay(120) | stop_if_should_exit(), |
| #!/usr/bin/env bash | ||
| #USE_HOST_NETWORK=True nohup bash -c '(litellm --config my-configs/litellm.yaml &) ; make run' &> output.log & | ||
| export USE_HOST_NETWORK=True | ||
| bash -c '(nohup bash -c "make run") &> output.log' |
There was a problem hiding this comment.
let's remove devcontainer here
docker_runtime_kwargs = { privileged = true }