Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log restart reason if runtime reports it #6455

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

raymyers
Copy link
Contributor

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

Previously, pod_status was passed from runtime-api. Recently, new fields were added to provide more detail: restart_count (number) and restart_reasons list of string. The out of memory scenario (Reason "OOM") is a motivation. This additional logging is intended to act gracefully when one or both of these fields is missing, although going forward they should be there.


Link of any specific issues this addresses

Copy link
Collaborator

@tofarr tofarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@raymyers
Copy link
Contributor Author

LGTM!

Thanks @tofarr. Feel free to mash the button at will.

@enyst enyst merged commit e619929 into All-Hands-AI:main Jan 25, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants