Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIT: Remove unused param #6446

Merged
merged 1 commit into from
Jan 24, 2025
Merged

NIT: Remove unused param #6446

merged 1 commit into from
Jan 24, 2025

Conversation

malhotra5
Copy link
Contributor

@malhotra5 malhotra5 commented Jan 24, 2025

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

Removes unused param


Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:aa2e03a-nikolaik   --name openhands-app-aa2e03a   docker.all-hands.dev/all-hands-ai/openhands:aa2e03a

@enyst
Copy link
Collaborator

enyst commented Jan 24, 2025

Just to make sure, the similar param here should stay?

@malhotra5
Copy link
Contributor Author

Yup! At some point unnecessary code was checked into the resolve_issue.py, which I'm cleaning up

Copy link
Collaborator

@enyst enyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, LGTM!

@malhotra5 malhotra5 enabled auto-merge (squash) January 24, 2025 14:31
@malhotra5 malhotra5 merged commit 45a048f into main Jan 24, 2025
14 checks passed
@malhotra5 malhotra5 deleted the fix/rm-unused-param branch January 24, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants