Fix: Filtering conversations with no created at #6414
Conversation
| @@ -40,6 +40,8 @@ async def get_metadata(self, conversation_id: str) -> ConversationMetadata: | |||
|
|
|||
| # Temp: force int to str to stop pydandic being, well... pedantic | |||
| json_obj = json.loads(json_str) | |||
| if 'created_at' not in json_obj: | |||
| raise FileNotFoundError(path) | |||
There was a problem hiding this comment.
Why wouldn't it have a created_at?
There was a problem hiding this comment.
If it's older than this feature 😄
We currently see a lot of "55 years ago" timestamps
There was a problem hiding this comment.
Ah... I wonder if we could just add a created_at if it's missing.
There was a problem hiding this comment.
Conversations are not implemented anywhere else than server currently, but I don't think it's difficult to do, at least in some basic way. This code is outside server. So I wonder if it makes sense to be lenient: once implemented elsewhere, e.g. cli, old streams could be loaded using conversations (replacing/using the session name).
There was a problem hiding this comment.
Older entries from the start of January didn't have this field yet.
There was a problem hiding this comment.
If they don't have it, they fail to load, right? An alternative is to allow them to load and provide something (initialize it with now)
Maybe it doesn't matter a lot, admittedly, because there aren't many that both have metadata and don't have this field.
Filter out older conversations that don't have all required details
Filtering out conversations that don't have a 'created_at' field. (The top 2 in the screenshot below):
To run this PR locally, use the following command: