Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable memory condensation from the frontend #6333

Merged
merged 17 commits into from
Jan 27, 2025
Merged

Enable memory condensation from the frontend #6333

merged 17 commits into from
Jan 27, 2025

Conversation

csmith49
Copy link
Collaborator

@csmith49 csmith49 commented Jan 17, 2025 •
edited
Loading

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

This PR adds a feature flag -- FEATURE_MEMORY_CONDENSER -- to enable the current best-performing memory condensation strategy.

Link of any specific issues this addresses

#5715

@csmith49 csmith49 marked this pull request as ready for review January 27, 2025 14:53
@csmith49 csmith49 requested a review from tofarr January 27, 2025 14:53
tofarr
tofarr approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@tofarr tofarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰 Good Job.

  • The setting will be set from the feature flag.
  • If missing on the server side in existing configs, it will be set to false.

@csmith49 csmith49 merged commit 12dd23b into All-Hands-AI:main Jan 27, 2025
16 checks passed
@csmith49 csmith49 mentioned this pull request Feb 1, 2025
Closed
zchn pushed a commit to zchn/OpenHands that referenced this pull request Feb 4, 2025
@csmith49
Enable memory condensation from the frontend (All-Hands-AI#6333)
f81e01a 
Co-authored-by: Calvin Smith <[email protected]>
idagelic pushed a commit to idagelic/OpenHands that referenced this pull request Feb 12, 2025
@csmith49 @idagelic
Enable memory condensation from the frontend (All-Hands-AI#6333)
7da5afd 
Co-authored-by: Calvin Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbren rbren rbren approved these changes

@tofarr tofarr tofarr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@csmith49 @rbren @tofarr