Agent session no longer stuck in starting on raised exception (#6703)

All-Hands-AI · Feb 13, 2025 · cb5e7f0 · cb5e7f0
1 parent 312b9fb
commit cb5e7f0
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 36 deletions.
diff --git a/openhands/runtime/impl/remote/remote_runtime.py b/openhands/runtime/impl/remote/remote_runtime.py
@@ -92,8 +92,9 @@ def _get_action_execution_server_host(self):
     async def connect(self):
         try:
             await call_sync_from_async(self._start_or_attach_to_runtime)
-        except AgentRuntimeNotReadyError:
-            self.log('error', 'Runtime failed to start, timed out before ready')
+        except Exception:
+            self.close()
+            self.log('error', 'Runtime failed to start')
             raise
         await call_sync_from_async(self.setup_initial_env)
         self._runtime_initialized = True

diff --git a/openhands/server/session/agent_session.py b/openhands/server/session/agent_session.py
@@ -99,42 +99,43 @@ async def start(
             return
         self._starting = True
         self._started_at = time.time()
-        self._create_security_analyzer(config.security.security_analyzer)
-        await self._create_runtime(
-            runtime_name=runtime_name,
-            config=config,
-            agent=agent,
-            github_token=github_token,
-            selected_repository=selected_repository,
-            selected_branch=selected_branch,
-        )
-
-        self.controller = self._create_controller(
-            agent,
-            config.security.confirmation_mode,
-            max_iterations,
-            max_budget_per_task=max_budget_per_task,
-            agent_to_llm_config=agent_to_llm_config,
-            agent_configs=agent_configs,
-        )
-        if github_token:
-            self.event_stream.set_secrets(
-                {
-                    'github_token': github_token.get_secret_value(),
-                }
-            )
-        if initial_message:
-            self.event_stream.add_event(initial_message, EventSource.USER)
-            self.event_stream.add_event(
-                ChangeAgentStateAction(AgentState.RUNNING), EventSource.ENVIRONMENT
-            )
-        else:
-            self.event_stream.add_event(
-                ChangeAgentStateAction(AgentState.AWAITING_USER_INPUT),
-                EventSource.ENVIRONMENT,
+        try:
+            self._create_security_analyzer(config.security.security_analyzer)
+            await self._create_runtime(
+                runtime_name=runtime_name,
+                config=config,
+                agent=agent,
+                github_token=github_token,
+                selected_repository=selected_repository,
+                selected_branch=selected_branch,
             )
 
-        self._starting = False
+            self.controller = self._create_controller(
+                agent,
+                config.security.confirmation_mode,
+                max_iterations,
+                max_budget_per_task=max_budget_per_task,
+                agent_to_llm_config=agent_to_llm_config,
+                agent_configs=agent_configs,
+            )
+            if github_token:
+                self.event_stream.set_secrets(
+                    {
+                        'github_token': github_token.get_secret_value(),
+                    }
+                )
+            if initial_message:
+                self.event_stream.add_event(initial_message, EventSource.USER)
+                self.event_stream.add_event(
+                    ChangeAgentStateAction(AgentState.RUNNING), EventSource.ENVIRONMENT
+                )
+            else:
+                self.event_stream.add_event(
+                    ChangeAgentStateAction(AgentState.AWAITING_USER_INPUT),
+                    EventSource.ENVIRONMENT,
+                )
+        finally:
+            self._starting = False
 
     async def close(self):
         """Closes the Agent session"""