[QC-1031]: changed origin for QC Check #2170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knopers8
reviewed
Mar 11, 2024
Framework/src/Check.cxx
Outdated
| return { "QC", createCheckDataDescription(checkName), 0, framework::Lifetime::Sporadic }; | ||
| using Origin = o2::header::DataOrigin; | ||
| Origin header; | ||
| header.runtimeInit(std::string{ "C" }.append(detector.substr(0, Origin::size)).c_str()); |
There was a problem hiding this comment.
Suggested change
| header.runtimeInit(std::string{ "C" }.append(detector.substr(0, Origin::size)).c_str()); | |
| header.runtimeInit(std::string{ "C" }.append(detector.substr(0, Origin::size - 1)).c_str()); |
If you get a 4-letter detector code, won't you pass a 5-letter string to runtimeInit?
FYI, we allow for some detector names which are longer than 3, but it's OK to trim them:
There was a problem hiding this comment.
Also, I would propose to extract the logic into a separate createCheckDataOrigin method.
knopers8
added a commit
to knopers8/QualityControl
that referenced
this pull request
Mar 15, 2024
This reverts commit cd342d8.
knopers8
added a commit
to knopers8/QualityControl
that referenced
this pull request
Mar 15, 2024
This reverts commit cd342d8.
knopers8
added a commit
that referenced
this pull request
Mar 15, 2024
knopers8
added a commit
that referenced
this pull request
Mar 15, 2024
knopers8
added a commit
to knopers8/QualityControl
that referenced
this pull request
Mar 15, 2024
…2170)" (AliceO2Group#2181)" This reverts commit fcbef09.
knopers8
added a commit
that referenced
this pull request
Mar 18, 2024
* Revert "Revert "[QC-1031]: changed origin for QC Check (#2170)" (#2181)" This reverts commit fcbef09. * Use correct check data origin as inputs of aggregators Also: - respect the ID/name distinction for check/aggregator data source specs - fix the relevant tests, which had aggregators referring to non-existent checks, which is now required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.