Add histo for TrendingTask #2167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Barthelemy
reviewed
Mar 7, 2024
| @@ -159,6 +165,22 @@ Quality DigitsQcCheck::check(std::map<std::string, std::shared_ptr<MonitorObject | |||
| mQualityMap[item.second->getName()] = qual; | |||
| } // if mNTFInSeconds > 0. | |||
| } | |||
| if (item.second->getName() == "NbLBEmpty") { | |||
| auto histo = static_cast<TH1F*>(item.second->getObject()); | |||
There was a problem hiding this comment.
why not use a dynamic cast and make sure that the result is not a nullptr ?
There was a problem hiding this comment.
I don't know, all histo are like this in the checks. Can you tell me what I have to change exactly. And is it for all history in checks part or only for this one?
There was a problem hiding this comment.
In general, you could try to use
auto histo = dynamic_cast<TH1F*>(item.second->getObject());
if (histo) {
// do something with the plot
} else {
// something went wrong
}
I let you investigate this safer option and perhaps submit another PR as to not block this one. This could apply to all the static casts.
Barthelemy
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.