QC-686 Allow apply Reductors to CCDB data in TrendingTasks and alike #2110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knopers8
requested review from
iravasen,
IsakovAD,
wiechula,
mfasDa,
jokonig,
Barthelemy and
njacazio
as code owners
knopers8
changed the title
This commit brings the possibility to apply Reductors to CCDB objects. To achieve that, the former Reductor (which assumes the expected type as TObject*) has become ReductorTObject, while ReductorConditionAny lets us retrieve any type which has a dictionary with retrieveConditionAny method. For better separation and easier testability, I extracted that method into a separate ConditionAccess class.
assuming the presence of the expected object in the database for given timestamps, the LHC phase can be trended with the following config:
```
"LHCClockPhaseTrend": {
"active": "true",
"className": "o2::quality_control::postprocessing::TrendingTask",
"moduleName": "QualityControl",
"detectorName": "TST",
"dataSources": [
{
"type": "condition",
"path": "TOF/Calib",
"names": [ "LHCphase" ],
"reductorName": "o2::quality_control_modules::common::LHCClockPhaseReductor",
"moduleName": "QcCommon"
}
],
"plots": [
{
"name": "lhc_phase",
"title": "LHC Phase trend",
"varexp": "LHCphase.phase:time",
"selection": "",
"option": "*L",
"graphAxisLabel": "Mean X:time"
}
],
"initTrigger": [
"userorcontrol"
],
"updateTrigger": [
"10 seconds"
],
"stopTrigger": [
"userorcontrol"
]
}
```
knopers8
force-pushed
the
ccdb-trending
branch
from
a7d75f4 to
181f391
Compare
|
@ercolessi FYI, I could get a seemingly valid trend with the attached postprocessing-lhc-clock.json and the following execution command: Also tagging @mlesch , who would be probably interested in seeing a real-world example of a ccdb object reductor (see |
|
@Barthelemy ready for review |
Barthelemy
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ugly, but working... I am still looking into ways of better separation between
ObjectGetterandUserCodeInterfaceand avoid renaming all the currently inheritedReductors.Some cleanups still needed as well