-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QC-1075] Allow for multiple data sources in QC tasks #2098
Conversation
Which, effectively, allows to declary CCDB inputs as direct alongside of a data sampling policy
Hi @mfasDa , this PR, in combination with the attached config file, allows to put CCDB inputs as direct in combination with a sampling policy. On my setup, I was getting valid results, but perhaps I am missing something. Could you please give it a go as well? The way to configure might change a bit, but the underlying behaviour should stay the same... that is assuming that you confirm this works as expected. |
@mfasDa Since you might be busy with something else, I will propose to move on with this PR, then later we can address any issues you might encounter while trying it. @Barthelemy Ready for review |
@knopers8 do I understand correctly that all the config files will have to be adapted ? |
No, it is backwards-compatible. |
indeed, sorry, I missed one line |
waiting for |
Hi @knopers8 , Hi @Barthelemy , Sorry for the late reply! The solution works for us. I get both the CCDB objects and the downsampled data. Our PR can now also be merged. Thanks a lot for your help! |
Which, effectively, allows to declary CCDB inputs as direct alongside of a data sampling policy.
To my impression, it seems to work with the example provided by Markus.
To be decided if allowing for multiple data sources is the best way forward. The users might try to combine direct data sources with sampled sources, which will normally leave plenty of partially filled timeslices which are never executed. However, this generalization is in line with multiple data sources for Checks and Aggregators.
A possible approach would be to declare a ccdb data source, which is interally treated as direct, but can be explicitely asserted that it is used in combination with a data sampling policy.